Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate parameters file upon configuration save in settings #38

Open
wasimsandhu opened this issue Oct 14, 2022 · 0 comments
Open

Generate parameters file upon configuration save in settings #38

wasimsandhu opened this issue Oct 14, 2022 · 0 comments
Labels
enhancement Improvements to current functionality

Comments

@wasimsandhu
Copy link
Contributor

wasimsandhu commented Oct 14, 2022 •
edited
Loading

Currently, the parameters file is only generated on new job setup. This means that any changes in Settings > MS-DIAL Configurations during an active run would have no effect, because no new parameters.txt file is created.

Instead, call the generate_msdial_parameters_file() function from the DatabaseFunctions module on each save of MS-DIAL configuration parameters. You could just insert this call to the end of the update_msdial_configuration() function.
@wasimsandhu wasimsandhu self-assigned this Oct 14, 2022
@wasimsandhu wasimsandhu closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2022
@wasimsandhu wasimsandhu reopened this Feb 16, 2023
@wasimsandhu wasimsandhu removed their assignment Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvements to current functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wasimsandhu