Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate warnings into separate section in comments #91

Open
spruce opened this issue Apr 14, 2015 · 5 comments
Open

Separate warnings into separate section in comments #91

spruce opened this issue Apr 14, 2015 · 5 comments

Comments

@spruce
Copy link

spruce commented Apr 14, 2015

Hey there,
maybe it would be nicer to write and make clear that warnings are not necessary totally wrong and one can also proceed with issue even when warnings are still there.
Example: twbs/bootstrap#16285 (comment)

@cvrebert
Copy link
Owner

Meh, better safe than sorry, IMHO.

@spruce
Copy link
Author

spruce commented Apr 14, 2015

Sure

@stephtr
Copy link

stephtr commented Feb 27, 2016

But what about false-positives? In these cases the code has to be edited (maybe complicated) even though it could be correct.

@cvrebert cvrebert removed the wontfix label Feb 27, 2016
@cvrebert cvrebert changed the title only warnings still writes fix errors Separate warnings into separate section in comments Feb 27, 2016
@cvrebert cvrebert reopened this Feb 27, 2016
@spruce
Copy link
Author

spruce commented Mar 20, 2016

What exactly do you mean. Was the question even directed to me?

@stephtr
Copy link

stephtr commented Mar 20, 2016

My question was for cvrebert, if it is better to have false-positives or to be not "safe".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants