Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Extracting code from main packages into server and client packages #533

Open
oxisto opened this issue Apr 19, 2024 · 0 comments
Open
Assignees

Comments

@oxisto
Copy link
Contributor

oxisto commented Apr 19, 2024

As mentioned in #367, we are currently trying to integrate this repository into our Clouditor open-source cloud security solution (see clouditor/clouditor#1414 for more information). Basically, we could make use of the csaf_provider (for testing) as well as the csaf_checker to perform and integrate conformance checks. However, currently, the majority of the code of both resides in the main package, making it impossible to use from an external source.

I would therefore propose to move everything except the main.go out of the respective main packages. This would then result in a folder structure similar to this:

cmd/csaf_provider
  main.go
csaf
  models.go
  ...
  server
    provider
      controller.go
      ...
    aggregator
      ...
  client
    checker
      processor.go
      rules.go
      ...
    downloader
      ...

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants