Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate ops that access class attributes from the rest #123

Closed
llorllale opened this issue Jan 29, 2018 · 6 comments
Closed

Differentiate ops that access class attributes from the rest #123

llorllale opened this issue Jan 29, 2018 · 6 comments

Comments

@llorllale
Copy link
Contributor

Following on from this comment:

We need a way to differentiate <op> that access the class' attributes from other ops that don't. LCOM5 (#18) needs this.

@0crat
Copy link
Collaborator

0crat commented Jan 29, 2018

@yegor256/z please, pay attention to this issue

@yegor256
Copy link
Member

@llorllale but we have it already. If an op accesses an object attribute it has type equal to put or get.

@llorllale
Copy link
Contributor Author

llorllale commented Jan 29, 2018

@yegor256 sorry, did not see it documented anywhere (and didn't look at code). Are the plans to add more types that access attributes? Will fixing #114 involve adding a new type?

@yegor256
Copy link
Member

@llorllale maybe, if new metrics will require them.

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2018

Job gh:yegor256/jpeek#123 is not assigned, can't get start time

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2018

Job #123 was not in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants