Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceled orders still appear on restaurant tablets unless you hard refresh the app #1853

Open
Srywards opened this issue Aug 19, 2024 · 9 comments
Labels
Food Tech Restaurant Interface An issue related to a restaurant´s interface. Ex: Orders dashboard, monthly income, opening hours

Comments

@Srywards
Copy link

Describe the bug
Canceled orders still appear on restaurant tablets unless you hard refresh the app

To Reproduce
Steps to reproduce the behavior:
Cancel an order made on Monday (for example but all day is included) evening but which fell the next day at noon

Expected behavior
Orders must be appear canceled for the restaurant without hard refresh the app

@Srywards Srywards added the bug label Aug 19, 2024
@Paul-Eraman-CoopCycle
Copy link

@vladimir-8

@Atala Atala transferred this issue from coopcycle/coopcycle-web Aug 20, 2024
@Atala
Copy link
Member

Atala commented Aug 22, 2024

Tested OK in good conditions (local setup)

@AdrienSICKLO
Copy link

AdrienSICKLO commented Sep 30, 2024

Order CWSG on Naofood, validated 29th at 0:02am and remade by restaurant last night

@Atala
Copy link
Member

Atala commented Oct 2, 2024

Tested OK in a restaurant so quite likely a network issue

@Paul-Eraman-CoopCycle Paul-Eraman-CoopCycle closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2024
@AdrienSICKLO
Copy link

Dispatchers here are quite doubtful about the network theory... We'll keep investigating but looks like a pattern.
Why would orders go from New to Accepted to Finished when the rider drops it, but canceled would not go to canceled?

@Paul-Eraman-CoopCycle
Copy link

There is a different path for cancellation than other actions

There is an issue about that by @Atala that i can find when I'm not on my phone that would probably fix any issues happening with this

Either way, the tasks should update, just not exactly the same second

@Atala
Copy link
Member

Atala commented Oct 14, 2024

hello

the code to handle order update changes is definitely the same ref

i think your dispatcher have a confirmation biases because the order not showing as cancelled for the restaurant is the most painful one.
if i am not wrong
new -> accepted is done by the restaurant itself
accepted -> finished restaurant don't really care

so now i have tested it alright locally and tested it alright with 3 different devices at glasgow burger (sunmi 2vs, sunmi, my phone). i saw the cancellation happen.

what i did test not OK on wattignies network is leaving the network, place an order, joining the network again and not see a new order popup.

so i would say 95.7% sure it is a network issue until proven wrong.

we know for sure that the fix should be this = resend messages when the connection was cut. but we are not there yet.

BUT

I have another potential fix and i am planning to do it just for you extra because i know it is a pain for you. i ll let you know.

@Atala Atala reopened this Oct 14, 2024
@Atala
Copy link
Member

Atala commented Oct 14, 2024

(the issue speaks more precisely of an order that was made for the next day, that might be a different issue but I dont think so as wellà

@Paul-Eraman-CoopCycle
Copy link

then can we close this and track in #78?

@Paul-Eraman-CoopCycle Paul-Eraman-CoopCycle added Restaurant Interface An issue related to a restaurant´s interface. Ex: Orders dashboard, monthly income, opening hours Food Tech and removed bug labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Food Tech Restaurant Interface An issue related to a restaurant´s interface. Ex: Orders dashboard, monthly income, opening hours
Projects
None yet
Development

No branches or pull requests

4 participants