Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need an e2e test for nydus integrated with p2p #438

Open
sctb512 opened this issue Mar 29, 2023 · 2 comments
Open

Need an e2e test for nydus integrated with p2p #438

sctb512 opened this issue Mar 29, 2023 · 2 comments

Comments

@sctb512
Copy link
Member

sctb512 commented Mar 29, 2023

We should add an e2e test for nydus integrated with p2p, which includes the following cases:

  1. p2p is the only mirror and does not work, fall back to the original registry.
  2. p2p is the only mirror and works, all is well.
  3. p2p is not the only mirror and does not work, try the next mirror.
  4. p2p is the only mirror and auth_through is true, unauthorized requests are sent to the p2p server.
  5. A normal registry is the only mirror(auth_through must be true).
@sctb512 sctb512 changed the title Need e2e test for nydus integrated with p2p Need an e2e test for nydus integrated with p2p Mar 29, 2023
@changweige
Copy link
Member

Thanks for considering this. Frankly speaking, the test for it is fragile.

@adamqqqplay
Copy link
Contributor

Currently, we do have some tests in https://github.com/dragonflyoss/Dragonfly2/actions/workflows/nydus-e2e.yml, but adding more tests would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants