-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow us to unsubscribe from a topic more easily #1193
Comments
Hey - while I don't think there is a plan to immediately add this enhancement right now, I can suggest a better workaround. You can use the |
ok thanks @milindl - I think this functionality is sorely needed - it would save users re-implementing their own unsubscribe logic. That means the library would store the references, which is fine I guess? Maybe only 10K items, tops. |
we have a lot of topics in Kafka and passing 500 topic ids 3x a second to unsubscribe is a bit scary. Is there no way to store a reference to the sub list on the kafka-side? it seems like this is a big oversight? |
I think the API is worth considering, but there are several things which means it will probably not be prioritized soon. This is a public API, once we support it, we'll need to support it forever. And we'd need to define the semantics of the method for regex-based subscriptions, for which there is more than one way to implement it, and thus requires more discussion. A similar method doesn't exist in the official Kafka Java client either. Added to that is the fact a workaround exists, and in my experience, changing subscriptions multiple times per second is not a very common mode of operation, since that incurs a rebalance (Even if you're using incremental rebalancing, there is some penalty to it). Could you help me understand the use case for subscribing and unsubscribing from a topic multiple times every second? That'd be helpful for me to discuss this with my team. |
Description
Unsubscribing to 1 topic, but not all topics, for a consumer is currently wonky
I want this:
but all we have is:
which unsubscribes us from all topics.
this is insane?
How to reproduce
here is how to unsubscribe from one topic, but not all topics -
The text was updated successfully, but these errors were encountered: