From aaa742c1e139dabacca6914dc2dd140a836da0af Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 18:18:44 +0800 Subject: [PATCH 001/130] . --- .github/workflows/run-mill-action.yml | 1 + .github/workflows/run-tests.yml | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/run-mill-action.yml b/.github/workflows/run-mill-action.yml index 9d667968e14..2823b055bd5 100644 --- a/.github/workflows/run-mill-action.yml +++ b/.github/workflows/run-mill-action.yml @@ -30,6 +30,7 @@ on: jobs: run: + if: github.event.pull_request.draft == false runs-on: ${{ inputs.os }} continue-on-error: ${{ inputs.continue-on-error }} timeout-minutes: ${{ inputs.timeout-minutes }} diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index ed862f35a90..ab00ac051dc 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -11,8 +11,6 @@ name: Run Tests on: push: - branches: - - main pull_request: workflow_dispatch: From f525f72410aa854a0ed27be7352f1cf1a1fbaedf Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 18:20:14 +0800 Subject: [PATCH 002/130] . --- .github/workflows/run-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index ab00ac051dc..cc5b879b2f6 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -12,6 +12,8 @@ name: Run Tests on: push: pull_request: + pull_request_target: + types: [ ready_for_review ] workflow_dispatch: # cancel older runs of a pull request; From 237cc18bbd431bc4e950e05bb62083430bc05eaa Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 18:21:36 +0800 Subject: [PATCH 003/130] . --- .github/workflows/run-mill-action.yml | 1 - .github/workflows/run-tests.yml | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/run-mill-action.yml b/.github/workflows/run-mill-action.yml index 2823b055bd5..9d667968e14 100644 --- a/.github/workflows/run-mill-action.yml +++ b/.github/workflows/run-mill-action.yml @@ -30,7 +30,6 @@ on: jobs: run: - if: github.event.pull_request.draft == false runs-on: ${{ inputs.os }} continue-on-error: ${{ inputs.continue-on-error }} timeout-minutes: ${{ inputs.timeout-minutes }} diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index cc5b879b2f6..673103c8178 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -26,6 +26,7 @@ jobs: # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: + if: github.event.pull_request.draft == false uses: ./.github/workflows/run-mill-action.yml with: java-version: '11' @@ -33,6 +34,7 @@ jobs: populate_cache: true build-windows: + if: github.event.pull_request.draft == false uses: ./.github/workflows/run-mill-action.yml with: os: windows-latest From 51275ec03f091dcd63f011cd054111013a754fa5 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 18:23:07 +0800 Subject: [PATCH 004/130] . --- .github/workflows/run-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 673103c8178..b2359a3c49b 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -43,6 +43,7 @@ jobs: populate_cache: true test-docs: + if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From f4b27f615e95addff31bbaa70581363912983dfc Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 18:35:24 +0800 Subject: [PATCH 005/130] . --- .github/ISSUE_TEMPLATE.md | 1 + .github/workflows/run-tests.yml | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index d75fe1f170a..aa8ab8389ce 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -2,3 +2,4 @@ Please don't open issues for questions, but ask in our Discussions forum at http Mill installations via `coursier` or `cs` are unsupported. +Pull requests shou \ No newline at end of file diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index b2359a3c49b..92eddbd5df8 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -23,6 +23,22 @@ concurrency: cancel-in-progress: true jobs: + set_status: + runs-on: ubuntu-latest + permissions: + statuses: write + steps: + - name: Create status + run: | + curl --request POST \ + --url https://api.github.com/repos/${{ github.repository }}/statuses/${{ github.event.workflow_run.head_commit.id }} \ + --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ + --header 'content-type: application/json' \ + --data '{ + "state": "success", + "context": "Link To External Action", + "target_url": "${{ github.event.workflow_run.html_url }}" + }' \ # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: From d48aadbfaba0a5eb0f144b26f295fb0e365a455b Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 18:57:06 +0800 Subject: [PATCH 006/130] . --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 92eddbd5df8..98d8d83e9cd 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -37,7 +37,7 @@ jobs: --data '{ "state": "success", "context": "Link To External Action", - "target_url": "${{ github.event.workflow_run.html_url }}" + "target_url": "${{ github.event.pull_request.head.repo.clone_url }}/actions" }' \ # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into From ef6f54f78919693f94f5c8890f7f791b331db2c2 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 19:05:04 +0800 Subject: [PATCH 007/130] . --- .github/ISSUE_TEMPLATE.md | 4 +++- .github/workflows/run-tests.yml | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index aa8ab8389ce..95c8e149c20 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -2,4 +2,6 @@ Please don't open issues for questions, but ask in our Discussions forum at http Mill installations via `coursier` or `cs` are unsupported. -Pull requests shou \ No newline at end of file +Pull requests should be kept as drafts until ready for review and final merge, to avoid +being bottlenecked on the Github Actions budget of the Mill repo (Actions on draft PRs +will instead run on the author's Github Actions budget) \ No newline at end of file diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 98d8d83e9cd..021ce393f61 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -28,6 +28,9 @@ jobs: permissions: statuses: write steps: + - name: Get PR source repository URL + run: + echo "Source Repository URL: ${{ github.event.pull_request.head.repo.clone_url }}" - name: Create status run: | curl --request POST \ From 71053908ac068c484565fefa9e213b492c7bc286 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 19:09:42 +0800 Subject: [PATCH 008/130] . --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 021ce393f61..f963c229a94 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -30,7 +30,7 @@ jobs: steps: - name: Get PR source repository URL run: - echo "Source Repository URL: ${{ github.event.pull_request.head.repo.clone_url }}" + echo "${{ github.event.pull_request.head.repo.clone_url }}" - name: Create status run: | curl --request POST \ From 3969d751a5c55d7eba45accb7a0d41a74f87021a Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 19:18:27 +0800 Subject: [PATCH 009/130] . --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index f963c229a94..6068aba56dd 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -34,7 +34,7 @@ jobs: - name: Create status run: | curl --request POST \ - --url https://api.github.com/repos/${{ github.repository }}/statuses/${{ github.event.workflow_run.head_commit.id }} \ + --url https://api.github.com/repos/${{ github.repository }}/statuses/$GITHUB_SHA \ --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ From d0ca1a9e9740b8ccdc48e6443869b18cad614685 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 19:38:16 +0800 Subject: [PATCH 010/130] . --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 6068aba56dd..f17227bc983 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -34,7 +34,7 @@ jobs: - name: Create status run: | curl --request POST \ - --url https://api.github.com/repos/${{ github.repository }}/statuses/$GITHUB_SHA \ + --url ${{ github.event.pull_request.statuses_url }} \ --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ From c1c702672033c6105fc807b06953293168dc907b Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 19:54:00 +0800 Subject: [PATCH 011/130] . --- .github/workflows/run-tests.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index f17227bc983..5c864c75dde 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -34,14 +34,15 @@ jobs: - name: Create status run: | curl --request POST \ - --url ${{ github.event.pull_request.statuses_url }} \ + --url https://api.github.com/repos/${{ github.repository }}/statuses/${{ github.event.workflow_run.head_commit.id }} \ --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "success", - "context": "Link To External Action", - "target_url": "${{ github.event.pull_request.head.repo.clone_url }}/actions" + "state": "${{ github.event.workflow_run.conclusion }}", + "context": "unit test (kube)", + "target_url": "${{ github.event.workflow_run.html_url }}" }' \ + --fail # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: From 2163a6d02c5657f9303fd0d8b82b8548b7f7958a Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 19:55:35 +0800 Subject: [PATCH 012/130] . --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 5c864c75dde..3402685b8a4 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -34,7 +34,7 @@ jobs: - name: Create status run: | curl --request POST \ - --url https://api.github.com/repos/${{ github.repository }}/statuses/${{ github.event.workflow_run.head_commit.id }} \ + --url ${{ github.event.pull_request.statuses_url }} \ --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ From 31891069ed2475c64bc5b905a34dbf0e3daa8013 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 20:08:53 +0800 Subject: [PATCH 013/130] . --- .github/workflows/run-tests.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 3402685b8a4..9cfb57bc454 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -25,8 +25,7 @@ concurrency: jobs: set_status: runs-on: ubuntu-latest - permissions: - statuses: write + permissions: write-all steps: - name: Get PR source repository URL run: From 64801f5d0bf784e82ebe895089f2719c6530fe61 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 20:12:46 +0800 Subject: [PATCH 014/130] . --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 9cfb57bc454..1d94ee1fbaa 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -41,7 +41,7 @@ jobs: "context": "unit test (kube)", "target_url": "${{ github.event.workflow_run.html_url }}" }' \ - --fail + --fail-with-body # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: From 5e0cf5b476beaf2f64cb601872aa15a888eaac4b Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 21:22:36 +0800 Subject: [PATCH 015/130] . --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 1d94ee1fbaa..3a12b36f34c 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -8,7 +8,7 @@ name: Run Tests # - All tests on Linux/Java17 # - Fewer tests on Linux/Java11 and Windows/Java17 # - Fewest tests on Windows/Java11 - +permissions: write-all on: push: pull_request: From e9a9f3c61d15d9e6e938c2c5d11f6da744219ea7 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 21:46:10 +0800 Subject: [PATCH 016/130] . --- .github/workflows/draft-status.yml | 36 ++++++++++++++++++++++++++++++ .github/workflows/run-tests.yml | 22 ------------------ 2 files changed, 36 insertions(+), 22 deletions(-) create mode 100644 .github/workflows/draft-status.yml diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml new file mode 100644 index 00000000000..7d58c78a15d --- /dev/null +++ b/.github/workflows/draft-status.yml @@ -0,0 +1,36 @@ +name: Draft Status + +# We run full CI on push builds to main and on all pull requests +# +# Manual builds (workflow_dispatch) to the main branch are also published +# +# To maximize bug-catching changes while keeping CI times reasonable, we run: +# - All tests on Linux/Java17 +# - Fewer tests on Linux/Java11 and Windows/Java17 +# - Fewest tests on Windows/Java11 +permissions: write-all +on: + pull_request_target: + +# cancel older runs of a pull request; + +jobs: + set_status: + runs-on: ubuntu-latest + permissions: write-all + steps: + - name: Get PR source repository URL + run: + echo "${{ github.event.pull_request.head.repo.clone_url }}" + - name: Create status + run: | + curl --request POST \ + --url ${{ github.event.pull_request.statuses_url }} \ + --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ + --header 'content-type: application/json' \ + --data '{ + "state": "${{ github.event.workflow_run.conclusion }}", + "context": "unit test (kube)", + "target_url": "${{ github.event.workflow_run.html_url }}" + }' \ + --fail-with-body diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 3a12b36f34c..14469077d6a 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -8,12 +8,9 @@ name: Run Tests # - All tests on Linux/Java17 # - Fewer tests on Linux/Java11 and Windows/Java17 # - Fewest tests on Windows/Java11 -permissions: write-all on: push: pull_request: - pull_request_target: - types: [ ready_for_review ] workflow_dispatch: # cancel older runs of a pull request; @@ -23,25 +20,6 @@ concurrency: cancel-in-progress: true jobs: - set_status: - runs-on: ubuntu-latest - permissions: write-all - steps: - - name: Get PR source repository URL - run: - echo "${{ github.event.pull_request.head.repo.clone_url }}" - - name: Create status - run: | - curl --request POST \ - --url ${{ github.event.pull_request.statuses_url }} \ - --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ - --header 'content-type: application/json' \ - --data '{ - "state": "${{ github.event.workflow_run.conclusion }}", - "context": "unit test (kube)", - "target_url": "${{ github.event.workflow_run.html_url }}" - }' \ - --fail-with-body # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: From 271fc399dcbc4b23851b747e1cbd9ffd9ff78914 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 21:48:33 +0800 Subject: [PATCH 017/130] . --- .github/workflows/draft-status.yml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index 7d58c78a15d..9a98ea8fd33 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -1,19 +1,9 @@ name: Draft Status -# We run full CI on push builds to main and on all pull requests -# -# Manual builds (workflow_dispatch) to the main branch are also published -# -# To maximize bug-catching changes while keeping CI times reasonable, we run: -# - All tests on Linux/Java17 -# - Fewer tests on Linux/Java11 and Windows/Java17 -# - Fewest tests on Windows/Java11 permissions: write-all on: pull_request_target: -# cancel older runs of a pull request; - jobs: set_status: runs-on: ubuntu-latest From 222dbc48904b27b64eebd64464de7bad6d9275fe Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 21:56:41 +0800 Subject: [PATCH 018/130] . --- .github/workflows/draft-status.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index 9a98ea8fd33..bcc04877ebf 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -11,7 +11,7 @@ jobs: steps: - name: Get PR source repository URL run: - echo "${{ github.event.pull_request.head.repo.clone_url }}" + echo "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}" - name: Create status run: | curl --request POST \ @@ -19,8 +19,8 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "${{ github.event.workflow_run.conclusion }}", - "context": "unit test (kube)", + "state": "pending", + "context": "Link to Draft CI", "target_url": "${{ github.event.workflow_run.html_url }}" }' \ --fail-with-body From 0aed111d6d7ec93edcb64dd861af444c6f7f7588 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Thu, 12 Sep 2024 21:57:57 +0800 Subject: [PATCH 019/130] . --- .github/ISSUE_TEMPLATE.md | 3 --- .github/workflows/draft-status.yml | 4 ++-- .github/workflows/run-tests.yml | 6 +++--- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 95c8e149c20..d75fe1f170a 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -2,6 +2,3 @@ Please don't open issues for questions, but ask in our Discussions forum at http Mill installations via `coursier` or `cs` are unsupported. -Pull requests should be kept as drafts until ready for review and final merge, to avoid -being bottlenecked on the Github Actions budget of the Mill repo (Actions on draft PRs -will instead run on the author's Github Actions budget) \ No newline at end of file diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index bcc04877ebf..4c277496910 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -19,8 +19,8 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "pending", - "context": "Link to Draft CI", + "state": "{{ github.event.workflow_run.conclusion }}", + "context": "Link to Fork CI", "target_url": "${{ github.event.workflow_run.html_url }}" }' \ --fail-with-body diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 14469077d6a..ed862f35a90 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -8,8 +8,11 @@ name: Run Tests # - All tests on Linux/Java17 # - Fewer tests on Linux/Java11 and Windows/Java17 # - Fewest tests on Windows/Java11 + on: push: + branches: + - main pull_request: workflow_dispatch: @@ -23,7 +26,6 @@ jobs: # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: - if: github.event.pull_request.draft == false uses: ./.github/workflows/run-mill-action.yml with: java-version: '11' @@ -31,7 +33,6 @@ jobs: populate_cache: true build-windows: - if: github.event.pull_request.draft == false uses: ./.github/workflows/run-mill-action.yml with: os: windows-latest @@ -40,7 +41,6 @@ jobs: populate_cache: true test-docs: - if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From c371991132f474e096d9b33e41a4c9fbe3a625b7 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 12:19:59 +0800 Subject: [PATCH 020/130] . --- .github/workflows/run-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index ed862f35a90..b5c275e19c3 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -11,8 +11,6 @@ name: Run Tests on: push: - branches: - - main pull_request: workflow_dispatch: @@ -26,6 +24,7 @@ jobs: # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: + if: github.event.pull_request.draft == false uses: ./.github/workflows/run-mill-action.yml with: java-version: '11' @@ -33,6 +32,7 @@ jobs: populate_cache: true build-windows: + if: github.event.pull_request.draft == false uses: ./.github/workflows/run-mill-action.yml with: os: windows-latest From 1d860d1d0f0b5454f4d06aae54d0fe0b513903ae Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 12:21:32 +0800 Subject: [PATCH 021/130] . --- .github/workflows/draft-status.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index 4c277496910..9a3da3b3dbf 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -14,6 +14,7 @@ jobs: echo "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}" - name: Create status run: | + set -eux curl --request POST \ --url ${{ github.event.pull_request.statuses_url }} \ --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ From aa75cc12af271f1f9f935229081656af416169a3 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 12:22:25 +0800 Subject: [PATCH 022/130] . --- .github/workflows/draft-status.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index 9a3da3b3dbf..3ffaded41f0 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -20,7 +20,7 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "{{ github.event.workflow_run.conclusion }}", + "state": "${{ github.event.workflow_run.conclusion }}", "context": "Link to Fork CI", "target_url": "${{ github.event.workflow_run.html_url }}" }' \ From e7bda40e4e14b79c40ce4eea90ed4486cd557e8a Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 12:22:40 +0800 Subject: [PATCH 023/130] . --- .github/workflows/draft-status.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index 3ffaded41f0..249899e32b6 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -14,7 +14,6 @@ jobs: echo "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}" - name: Create status run: | - set -eux curl --request POST \ --url ${{ github.event.pull_request.statuses_url }} \ --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ From 22da890c20c4c1cd9231153a1b50f652dc392eca Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 12:23:22 +0800 Subject: [PATCH 024/130] . From 2b11c7674f0f0db99180365ba32e30a1caf57e32 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 12:24:42 +0800 Subject: [PATCH 025/130] . --- .github/workflows/draft-status.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index 249899e32b6..b0cfb65e44c 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -19,7 +19,7 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "${{ github.event.workflow_run.conclusion }}", + "state": "pending", "context": "Link to Fork CI", "target_url": "${{ github.event.workflow_run.html_url }}" }' \ From 247cc90075b5c6ba63ef27c235504852b6838d00 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 12:24:56 +0800 Subject: [PATCH 026/130] . --- .github/workflows/draft-status.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index b0cfb65e44c..c1ffbf0c497 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -21,6 +21,6 @@ jobs: --data '{ "state": "pending", "context": "Link to Fork CI", - "target_url": "${{ github.event.workflow_run.html_url }}" + "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}" }' \ --fail-with-body From 4d718eeeacbe61ee41a15dc9972bdc9d8ed50baa Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 12:26:23 +0800 Subject: [PATCH 027/130] . From 45b7f19339388e99170ce64b4aad7f8d4f262c21 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 12:28:30 +0800 Subject: [PATCH 028/130] . --- .github/workflows/run-tests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index ed862f35a90..11000e4397d 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -26,6 +26,7 @@ jobs: # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: + if: github.event.pull_request.draft == false uses: ./.github/workflows/run-mill-action.yml with: java-version: '11' @@ -33,6 +34,7 @@ jobs: populate_cache: true build-windows: + if: github.event.pull_request.draft == false uses: ./.github/workflows/run-mill-action.yml with: os: windows-latest @@ -41,6 +43,7 @@ jobs: populate_cache: true test-docs: + if: github.event.pull_request.draft == false runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From 9ced8e674e4ca1484f886024fe59e1420a258b99 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 12:32:29 +0800 Subject: [PATCH 029/130] . --- .github/workflows/draft-status.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index c1ffbf0c497..6118b2cf57a 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -6,6 +6,7 @@ on: jobs: set_status: + if: github.event.pull_request.draft == true runs-on: ubuntu-latest permissions: write-all steps: From c0e564e7ab9075f6942d741847e97ebe6c6835d3 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:11:37 +0800 Subject: [PATCH 030/130] . --- .github/workflows/run-tests.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 82b5c369e4e..377718b9571 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -12,6 +12,11 @@ name: Run Tests on: push: pull_request: + types: + - opened + - reopened + - synchronize + - ready_for_review workflow_dispatch: # cancel older runs of a pull request; From 555f6552d743470ec746cf4dcef3c9f12da5fd3c Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:11:50 +0800 Subject: [PATCH 031/130] . From 1aa771814eb1455eecc299928ff8ac01d77626b5 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:13:08 +0800 Subject: [PATCH 032/130] . From 135ac3a2e389a753f129c6bedb0a212ea0a30915 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:14:54 +0800 Subject: [PATCH 033/130] . --- .github/workflows/run-tests.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 377718b9571..c2f74dabebc 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -26,6 +26,11 @@ concurrency: cancel-in-progress: true jobs: + set_status: + runs-on: ubuntu-latest + steps: + - name: Echo Concurrency Key + run: echo 'cancel-old-pr-runs-${{ github.workflow }}-${{ github.head_ref || github.run_id }}' # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: From 944aba26eff5f414a4578fee068783cff02ae7da Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:15:52 +0800 Subject: [PATCH 034/130] . --- .github/workflows/run-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index c2f74dabebc..e78a2786b7b 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -22,7 +22,7 @@ on: # cancel older runs of a pull request; # this will not cancel anything for normal git pushes concurrency: - group: cancel-old-pr-runs-${{ github.workflow }}-${{ github.head_ref || github.run_id }} + group: cancel-old-pr-runs-${{ github.workflow }}-${{ github.head_ref }} cancel-in-progress: true jobs: @@ -30,7 +30,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Echo Concurrency Key - run: echo 'cancel-old-pr-runs-${{ github.workflow }}-${{ github.head_ref || github.run_id }}' + run: echo 'cancel-old-pr-runs-${{ github.workflow }}-${{ github.head_ref }}' # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: From cbcec4523f9d777032fa48361e6dad3bd151cf34 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:17:08 +0800 Subject: [PATCH 035/130] . --- .github/workflows/run-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index e78a2786b7b..38a17252de2 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -22,7 +22,7 @@ on: # cancel older runs of a pull request; # this will not cancel anything for normal git pushes concurrency: - group: cancel-old-pr-runs-${{ github.workflow }}-${{ github.head_ref }} + group: cancel-old-pr-runs-${{ github.workflow }}-${{ github.ref_name }} cancel-in-progress: true jobs: @@ -30,7 +30,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Echo Concurrency Key - run: echo 'cancel-old-pr-runs-${{ github.workflow }}-${{ github.head_ref }}' + run: echo 'cancel-old-pr-runs-${{ github.workflow }}-${{ github.ref_name }}' # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: From b512f139c244bf1710cdad8049ec0198ac02eb14 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:17:43 +0800 Subject: [PATCH 036/130] . From 5b444fd508835a119dee07b98c49c4334e645f13 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:20:14 +0800 Subject: [PATCH 037/130] . --- .github/workflows/publish-artifacts.yml | 6 ------ .github/workflows/run-tests.yml | 5 ----- 2 files changed, 11 deletions(-) diff --git a/.github/workflows/publish-artifacts.yml b/.github/workflows/publish-artifacts.yml index 7f1db0be4a7..c1d7a71a77e 100644 --- a/.github/workflows/publish-artifacts.yml +++ b/.github/workflows/publish-artifacts.yml @@ -14,12 +14,6 @@ on: - '**' workflow_dispatch: -# cancel older runs of a pull request; -# this will not cancel anything for normal git pushes -concurrency: - group: cancel-old-pr-runs-${{ github.workflow }}-${{ github.head_ref || github.run_id }} - cancel-in-progress: true - jobs: publish-sonatype: # when in master repo, publish all tags and manual runs on main diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 38a17252de2..1165cfa3093 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -26,11 +26,6 @@ concurrency: cancel-in-progress: true jobs: - set_status: - runs-on: ubuntu-latest - steps: - - name: Echo Concurrency Key - run: echo 'cancel-old-pr-runs-${{ github.workflow }}-${{ github.ref_name }}' # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: From 75dcf270775c956ee0b8cec2d8cbfe0e873d2fca Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:24:05 +0800 Subject: [PATCH 038/130] . --- .github/workflows/draft-status.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index 6118b2cf57a..4abe9d616f0 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -6,7 +6,7 @@ on: jobs: set_status: - if: github.event.pull_request.draft == true + if: 'github.event.pull_request.draft == true && github.event.type != 'ready_to_review'" runs-on: ubuntu-latest permissions: write-all steps: From 9611bf528f2a239dff5066e3d5e839120fb18e5b Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:25:31 +0800 Subject: [PATCH 039/130] . From e823a123e8fa98d0a27ac36b2ef4597dffec5360 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:29:01 +0800 Subject: [PATCH 040/130] . --- .github/workflows/draft-status.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index 4abe9d616f0..5d8a170daf7 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -6,7 +6,7 @@ on: jobs: set_status: - if: 'github.event.pull_request.draft == true && github.event.type != 'ready_to_review'" + if: github.event.pull_request.draft == true runs-on: ubuntu-latest permissions: write-all steps: @@ -21,7 +21,8 @@ jobs: --header 'content-type: application/json' \ --data '{ "state": "pending", - "context": "Link to Fork CI", - "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}" + "context": "Link to Fork Repo Actions", + "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", + "description": "use fork's github actions until ready for review", }' \ --fail-with-body From 0cdc3630555a5841f85bf69eec89972c1241b9ae Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:29:09 +0800 Subject: [PATCH 041/130] . From 92b91802ee7947b0705313005fe3e14584f3c75f Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:29:53 +0800 Subject: [PATCH 042/130] . From 07b887e9ffca41231894cb07131150b4812f932e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:31:09 +0800 Subject: [PATCH 043/130] . --- .github/workflows/draft-status.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index 5d8a170daf7..9290dbb9a15 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -23,6 +23,6 @@ jobs: "state": "pending", "context": "Link to Fork Repo Actions", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", - "description": "use fork's github actions until ready for review", + "description": "use fork github actions until ready for review", }' \ --fail-with-body From 72711a1180238d849b320bf89dedfaea698a3b26 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:31:10 +0800 Subject: [PATCH 044/130] . From 628675abad5703569fcba2cbea8bb3e93415d240 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:32:02 +0800 Subject: [PATCH 045/130] . From 950d9e4cac097f5aed9d3b07def9fdf69e4c009e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:34:30 +0800 Subject: [PATCH 046/130] . --- .github/workflows/draft-status.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index 9290dbb9a15..3ee8132f7f1 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -23,6 +23,6 @@ jobs: "state": "pending", "context": "Link to Fork Repo Actions", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", - "description": "use fork github actions until ready for review", + "description": "use fork github actions until ready for review" }' \ --fail-with-body From 590890663a45ffe84685ba0d39c82f60e6b2c9da Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:34:33 +0800 Subject: [PATCH 047/130] . From 81275e7f8890a07784c7407ea55f152276c34bd0 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:35:05 +0800 Subject: [PATCH 048/130] . From c5c7951268229acb71e37479d1e1fd75702d5a96 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:18:56 +0800 Subject: [PATCH 049/130] . --- .github/workflows/{draft-status.yml => draft-ci.yml} | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) rename .github/workflows/{draft-status.yml => draft-ci.yml} (81%) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-ci.yml similarity index 81% rename from .github/workflows/draft-status.yml rename to .github/workflows/draft-ci.yml index 3ee8132f7f1..b3dc3230c29 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-ci.yml @@ -1,11 +1,11 @@ -name: Draft Status +name: Draft CI permissions: write-all on: pull_request_target: jobs: - set_status: + run: if: github.event.pull_request.draft == true runs-on: ubuntu-latest permissions: write-all @@ -21,8 +21,8 @@ jobs: --header 'content-type: application/json' \ --data '{ "state": "pending", - "context": "Link to Fork Repo Actions", + "context": "Draft CI / run (pull_request_target)", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", - "description": "use fork github actions until ready for review" + "description": "use github actions on your repo fork until this PR is ready for review" }' \ --fail-with-body From d4d1d6d6c1b55032308812a74d8f3634ede6ca77 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:18:56 +0800 Subject: [PATCH 050/130] . From 747efc41997d619fa9702a72c5dd4f9bde8b77ac Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:19:42 +0800 Subject: [PATCH 051/130] . From a8d2b852ca7d2b544c515dd8ff128b19b2ccdc32 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:19:42 +0800 Subject: [PATCH 052/130] . From aa9a86bee543809f2d2b4ad5b59821b4cda89141 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:20:00 +0800 Subject: [PATCH 053/130] . From efd189fdace9f6705e5285d11dee5f2862550e96 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:20:00 +0800 Subject: [PATCH 054/130] . From 0fe03739ca4cf12f856f0f8e9d6e0831d8932fa9 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:20:07 +0800 Subject: [PATCH 055/130] . From 25374c947eb91743b19dee4ae20a89154ce7935e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:24:27 +0800 Subject: [PATCH 056/130] . --- .github/workflows/draft-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index b3dc3230c29..05c9170b5c8 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -21,7 +21,7 @@ jobs: --header 'content-type: application/json' \ --data '{ "state": "pending", - "context": "Draft CI / run (pull_request_target)", + "context": "Draft CI / link", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", "description": "use github actions on your repo fork until this PR is ready for review" }' \ From aaa10b812e0e2a449c4a205ad9f9bf7e96da2c35 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:24:27 +0800 Subject: [PATCH 057/130] . From fa41dc5376933cec87027ff9e7c5ead699673b16 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:24:34 +0800 Subject: [PATCH 058/130] . From aba7ec3ee04ada2d48cee8822dd7ed901f6e9558 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:27:18 +0800 Subject: [PATCH 059/130] . --- .github/ISSUE_TEMPLATE.md | 3 +++ .github/workflows/draft-ci.yml | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index d75fe1f170a..a1562c19df5 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -2,3 +2,6 @@ Please don't open issues for questions, but ask in our Discussions forum at http Mill installations via `coursier` or `cs` are unsupported. +Please open all PRs as drafts to avoid being bottlenecked by Mill CI, and only +convert to ready for review once CI on your own fork is green. There will be a +PR status check linking your fork's commit/CI history for convenient viewing \ No newline at end of file diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 05c9170b5c8..c13ae7ca7e3 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -23,6 +23,6 @@ jobs: "state": "pending", "context": "Draft CI / link", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", - "description": "use github actions on your repo fork until this PR is ready for review" + "description": "use CI on your repo fork (link on right) until this PR is ready for review" }' \ --fail-with-body From c1a2081d19ef8296b197b66378b25a5336360222 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:27:18 +0800 Subject: [PATCH 060/130] . From 8fcdc1782cd523b146199b8e8ddd6dfbcd32ea65 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:27:25 +0800 Subject: [PATCH 061/130] . From d71d521726ff11833a0f49886fc122bb68eeb7d1 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:29:36 +0800 Subject: [PATCH 062/130] . From d71c97e7507dcd596507fec1b5eaec3e898f91c7 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:29:36 +0800 Subject: [PATCH 063/130] . From d41363267a7dd4866642f6bbc2254e7c19a05330 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:29:43 +0800 Subject: [PATCH 064/130] . From 4484ebfc01e45956d95b79b1dbf160ba47e1e1bc Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:32:50 +0800 Subject: [PATCH 065/130] . --- .github/workflows/draft-ci.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index c13ae7ca7e3..97dd90b67f6 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -3,12 +3,16 @@ name: Draft CI permissions: write-all on: pull_request_target: + types: + - opened + - reopened + - synchronize jobs: run: if: github.event.pull_request.draft == true runs-on: ubuntu-latest - permissions: write-all + permissions: write-all steps: - name: Get PR source repository URL run: From 153f2730f80277982df25dcd4d51be58fb3bc159 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:32:50 +0800 Subject: [PATCH 066/130] . From a14817e66260f1b36398073e273bfb537f0feb9e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:32:57 +0800 Subject: [PATCH 067/130] . From ba3a4b64d79a81ae2c3215a2a7841b365b077d85 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:33:24 +0800 Subject: [PATCH 068/130] . From f1bf9fde0a0e4a2e36af58ed9b1d7ce0c44a2e11 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:33:24 +0800 Subject: [PATCH 069/130] . From d4dc387b1c6a8ca0ea1d24a856d43bcf41172ee4 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:33:31 +0800 Subject: [PATCH 070/130] . From 5bbc4932a9207544e7e0d54cffc63d7f9554231e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:38:21 +0800 Subject: [PATCH 071/130] . --- .github/workflows/draft-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 97dd90b67f6..68f0ac14569 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -7,10 +7,10 @@ on: - opened - reopened - synchronize + - ready_for_review jobs: run: - if: github.event.pull_request.draft == true runs-on: ubuntu-latest permissions: write-all steps: @@ -24,7 +24,7 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "pending", + "state": "${{ (github.event.action == 'ready_for_review' || github.event.pull_request.draft == true) && 'pending' || 'success'}}", "context": "Draft CI / link", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", "description": "use CI on your repo fork (link on right) until this PR is ready for review" From 389f55a3781d2b6bc599e1748aee2705e6d2bce9 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:38:21 +0800 Subject: [PATCH 072/130] . From b0358f20b7e110a951d480af44f185fcb857a19e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:38:29 +0800 Subject: [PATCH 073/130] . From 95534517c273ddd32894c843244313579bf79964 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:39:28 +0800 Subject: [PATCH 074/130] . From 179f76363f63c22ac93d025287918ec3d02d7f84 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:39:28 +0800 Subject: [PATCH 075/130] . From b79cb95de8755c281e9ce8f5ff495aa58bdc2aeb Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:39:35 +0800 Subject: [PATCH 076/130] . From 9854ef7a48bd134ced808c9414d61e2606f8a8ec Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:42:06 +0800 Subject: [PATCH 077/130] . --- .github/workflows/draft-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 68f0ac14569..571ddcb1c6e 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -15,7 +15,8 @@ jobs: permissions: write-all steps: - name: Get PR source repository URL - run: + run: | + echo ${{ github.event.action == 'ready_for_review' }} echo "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}" - name: Create status run: | From 52b6b5b44b0e9d8d7b7b2244e86b6a56a1a4552e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:42:06 +0800 Subject: [PATCH 078/130] . From 8d6f8796de07e3e9c68352a7f6eb7d927e9f02d1 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:42:13 +0800 Subject: [PATCH 079/130] . From fa68b7941a3211a299793966de71b03ef46ffc02 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:42:35 +0800 Subject: [PATCH 080/130] . --- .github/workflows/draft-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 571ddcb1c6e..f06756ae3cc 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -16,6 +16,7 @@ jobs: steps: - name: Get PR source repository URL run: | + echo ${{ github.event.action }} echo ${{ github.event.action == 'ready_for_review' }} echo "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}" - name: Create status From 35ab8e3503be0c8272fa7207fa45a8399a5cd408 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:42:35 +0800 Subject: [PATCH 081/130] . From a4de0ea21e94793e7bc227ecb5589d58f5838404 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:42:41 +0800 Subject: [PATCH 082/130] . From 3c9f8b56e6f3c05ba850cfcc9fc04449601caacb Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:44:52 +0800 Subject: [PATCH 083/130] . --- .github/workflows/draft-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index f06756ae3cc..b35bd38487f 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-latest permissions: write-all steps: - - name: Get PR source repository URL + - name: Debug Echos run: | echo ${{ github.event.action }} echo ${{ github.event.action == 'ready_for_review' }} @@ -26,7 +26,7 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "${{ (github.event.action == 'ready_for_review' || github.event.pull_request.draft == true) && 'pending' || 'success'}}", + "state": "${{ (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", "context": "Draft CI / link", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", "description": "use CI on your repo fork (link on right) until this PR is ready for review" From d2af03637f2812603cc579c104335dabe6df98de Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:44:52 +0800 Subject: [PATCH 084/130] . From fdf1f98096afd3b44927ee251a370c0f0ce1a694 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:44:58 +0800 Subject: [PATCH 085/130] . From 76c4d56fa5a93c5c2115aeb8efe9c819dae71917 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:49:53 +0800 Subject: [PATCH 086/130] . --- .github/workflows/draft-ci.yml | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index b35bd38487f..9682d2c74e1 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -26,9 +26,21 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "${{ (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", + "state": "${{ + (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) + && 'success' + || 'pending' + }}", "context": "Draft CI / link", - "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", - "description": "use CI on your repo fork (link on right) until this PR is ready for review" + "target_url": '${{ + (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) + && null + github.event.pull_request.head.repo.html_url + '/commits/' + github.event.pull_request.head.ref + }}', + "description": "${{ + (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) + && 'PR is ready for review, running CI in Mill repo' + || 'use CI on your repo fork (link on right) until this PR is ready for review' + }}" }' \ --fail-with-body From 1c36a22bdb656a3a6b3341b64223304eb8c5fd19 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:49:53 +0800 Subject: [PATCH 087/130] . From e1c8e8e5704365e4964fc00123ef07910e3b1012 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:50:00 +0800 Subject: [PATCH 088/130] . From 09ff98b06d43e9cf6f4e0784a6aa04af4912e405 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:50:57 +0800 Subject: [PATCH 089/130] . --- .github/workflows/draft-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 9682d2c74e1..3666790e4eb 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -35,7 +35,7 @@ jobs: "target_url": '${{ (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && null - github.event.pull_request.head.repo.html_url + '/commits/' + github.event.pull_request.head.ref + || github.event.pull_request.head.repo.html_url + '/commits/' + github.event.pull_request.head.ref }}', "description": "${{ (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) From 36a67699c8f53ab996a904b15d7d6dc0b8963c7e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:50:57 +0800 Subject: [PATCH 090/130] . From 7637df1b0e432dcf3c459d8963d46a1ff01a5496 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:51:03 +0800 Subject: [PATCH 091/130] . From d4aa9882063e870f7be54853c59af0ad93d452fa Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:53:05 +0800 Subject: [PATCH 092/130] . --- .github/workflows/draft-ci.yml | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 3666790e4eb..c5c3ec3de26 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -26,21 +26,9 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "${{ - (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) - && 'success' - || 'pending' - }}", + "state": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", "context": "Draft CI / link", - "target_url": '${{ - (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) - && null - || github.event.pull_request.head.repo.html_url + '/commits/' + github.event.pull_request.head.ref - }}', - "description": "${{ - (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) - && 'PR is ready for review, running CI in Mill repo' - || 'use CI on your repo fork (link on right) until this PR is ready for review' - }}" + "target_url": '${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && null || join([github.event.pull_request.head.repo.html_url, '/commits/', github.event.pull_request.head.ref])}}', + "description": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'PR is ready for review, running CI in Mill repo' || 'use CI on your repo fork (link on right) until this PR is ready for review'}}" }' \ --fail-with-body From a2eec7957a440d2cc05a44437af56fff226f05a6 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:53:05 +0800 Subject: [PATCH 093/130] . From 7a535cec8dbab47cd120f48ffc17376c25ddd5e9 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:53:12 +0800 Subject: [PATCH 094/130] . From dce0438eb8240f11b317cca77c20dd3e28a6de37 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:54:02 +0800 Subject: [PATCH 095/130] . --- .github/workflows/draft-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index c5c3ec3de26..38fc571016a 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -28,7 +28,7 @@ jobs: --data '{ "state": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", "context": "Draft CI / link", - "target_url": '${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && null || join([github.event.pull_request.head.repo.html_url, '/commits/', github.event.pull_request.head.ref])}}', + "target_url": '${{ github.event.pull_request.head.repo.html_url }}/commits/ ${{github.event.pull_request.head.ref}}', "description": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'PR is ready for review, running CI in Mill repo' || 'use CI on your repo fork (link on right) until this PR is ready for review'}}" }' \ --fail-with-body From 84507a5f18ca37efea0e6b55bc6ab0c0773e587f Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:54:02 +0800 Subject: [PATCH 096/130] . From c88ca3747b1bf6c6df5c42b0dc463afd79326ae8 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:54:09 +0800 Subject: [PATCH 097/130] . From a21d0ab6d4d2be1033a382039584f6f5e89a4f38 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:54:58 +0800 Subject: [PATCH 098/130] . --- .github/workflows/draft-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 38fc571016a..98a3cc8dc3d 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -28,7 +28,7 @@ jobs: --data '{ "state": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", "context": "Draft CI / link", - "target_url": '${{ github.event.pull_request.head.repo.html_url }}/commits/ ${{github.event.pull_request.head.ref}}', + "target_url": '${{join([github.event.pull_request.head.repo.html_url, '/commits/', github.event.pull_request.head.ref])}}', "description": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'PR is ready for review, running CI in Mill repo' || 'use CI on your repo fork (link on right) until this PR is ready for review'}}" }' \ --fail-with-body From 575b43fb9673435f00e73d4537f05974224d91ef Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:54:58 +0800 Subject: [PATCH 099/130] . From 2ff27cdbd28db4a3ce3e5a949b704bb263087f92 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:55:06 +0800 Subject: [PATCH 100/130] . From 97204778ec11062fadff5c8784f5444e612a34cf Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:56:22 +0800 Subject: [PATCH 101/130] . --- .github/workflows/draft-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 98a3cc8dc3d..c82c6486901 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -28,7 +28,7 @@ jobs: --data '{ "state": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", "context": "Draft CI / link", - "target_url": '${{join([github.event.pull_request.head.repo.html_url, '/commits/', github.event.pull_request.head.ref])}}', + "target_url": '${{format('{0}/commits/{1}', github.event.pull_request.head.repo.html_url, github.event.pull_request.head.ref)}}', "description": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'PR is ready for review, running CI in Mill repo' || 'use CI on your repo fork (link on right) until this PR is ready for review'}}" }' \ --fail-with-body From 12e835c140eb5d635eea0059f02402cbee056c64 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:56:22 +0800 Subject: [PATCH 102/130] . From a84d590b897ba2df54cd28bc3968e7d879806af4 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:56:28 +0800 Subject: [PATCH 103/130] . From 9866a44e3f60be19bcd328bb41e80fe6680d92d9 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:57:40 +0800 Subject: [PATCH 104/130] . --- .github/workflows/draft-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index c82c6486901..f106a42ec97 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -26,9 +26,9 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", + "state": "${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && 'pending' || 'success'}}", "context": "Draft CI / link", - "target_url": '${{format('{0}/commits/{1}', github.event.pull_request.head.repo.html_url, github.event.pull_request.head.ref)}}', - "description": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'PR is ready for review, running CI in Mill repo' || 'use CI on your repo fork (link on right) until this PR is ready for review'}}" + "target_url": ${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && format('"{0}/commits/{1}"', github.event.pull_request.head.repo.html_url, github.event.pull_request.head.ref) || null}}, + "description": "${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && 'use CI on your repo fork (link on right) until this PR is ready for review' || 'PR is ready for review, running CI in Mill repo'}}" }' \ --fail-with-body From 1c461209469058ca490f568ebb66d7a14e3d7cf7 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:57:40 +0800 Subject: [PATCH 105/130] . From 408e3125ed845b206960f4712ad88c2a0763aeac Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:57:47 +0800 Subject: [PATCH 106/130] . From bf94983fb95017ad512f53679ee99294b6134026 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:59:43 +0800 Subject: [PATCH 107/130] . --- .github/workflows/draft-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index f106a42ec97..a9b9fcee385 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -28,7 +28,7 @@ jobs: --data '{ "state": "${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && 'pending' || 'success'}}", "context": "Draft CI / link", - "target_url": ${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && format('"{0}/commits/{1}"', github.event.pull_request.head.repo.html_url, github.event.pull_request.head.ref) || null}}, + "target_url": ${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && format('"{0}/commits/{1}"', github.event.pull_request.head.repo.html_url, github.event.pull_request.head.ref) || 'null'}}, "description": "${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && 'use CI on your repo fork (link on right) until this PR is ready for review' || 'PR is ready for review, running CI in Mill repo'}}" }' \ --fail-with-body From 6ecef188dcff5d88d92d74281e93ceecdcdc14e9 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:59:43 +0800 Subject: [PATCH 108/130] . From b1b978a28c9cdff7750599d4ee2943e40a991e25 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:59:50 +0800 Subject: [PATCH 109/130] . From 49306e1eb66f5aab2ef061ac15cb37de462d5e46 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:01:30 +0800 Subject: [PATCH 110/130] . From 7bd2504131393ba76d474a3a8b20a19890c6d98c Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:01:30 +0800 Subject: [PATCH 111/130] . From c94eb480fa9cd5e92d74a77a2bddf0e5219f98c8 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:01:37 +0800 Subject: [PATCH 112/130] . From da719543c10027e6ce0ecca5cb760b18f73896f0 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:02:19 +0800 Subject: [PATCH 113/130] . --- .github/workflows/run-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 1165cfa3093..56446dfa660 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -29,7 +29,7 @@ jobs: # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: - if: github.event.pull_request.draft == false + if: github.event.action == 'ready_for_review' && github.event.pull_request.draft != false uses: ./.github/workflows/run-mill-action.yml with: java-version: '11' @@ -37,7 +37,7 @@ jobs: populate_cache: true build-windows: - if: github.event.pull_request.draft == false + if: github.event.action == 'ready_for_review' && github.event.pull_request.draft != false uses: ./.github/workflows/run-mill-action.yml with: os: windows-latest @@ -46,7 +46,7 @@ jobs: populate_cache: true test-docs: - if: github.event.pull_request.draft == false + if: github.event.action == 'ready_for_review' && github.event.pull_request.draft != false runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From eab25d00a693954ae9c17d01fa2613dbcd8fded7 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:02:19 +0800 Subject: [PATCH 114/130] . From a676bc2c82805d21d28aa54dd14cabe912ac2621 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:02:25 +0800 Subject: [PATCH 115/130] . From 46f0fdb49d361b53a59452fcfba5a46a19381dc2 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:02:50 +0800 Subject: [PATCH 116/130] . --- .github/workflows/run-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 56446dfa660..72637819453 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -29,7 +29,7 @@ jobs: # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: - if: github.event.action == 'ready_for_review' && github.event.pull_request.draft != false + if: github.event.action == 'ready_for_review' || github.event.pull_request.draft != false uses: ./.github/workflows/run-mill-action.yml with: java-version: '11' @@ -37,7 +37,7 @@ jobs: populate_cache: true build-windows: - if: github.event.action == 'ready_for_review' && github.event.pull_request.draft != false + if: github.event.action == 'ready_for_review' || github.event.pull_request.draft != false uses: ./.github/workflows/run-mill-action.yml with: os: windows-latest @@ -46,7 +46,7 @@ jobs: populate_cache: true test-docs: - if: github.event.action == 'ready_for_review' && github.event.pull_request.draft != false + if: github.event.action == 'ready_for_review' || github.event.pull_request.draft != false runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From bcd3655474a971ca6fbcd8daee6b7a06560c1967 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:02:50 +0800 Subject: [PATCH 117/130] . From 3c8efa6124b14de6bed4512129879d0a4d5f29af Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:02:57 +0800 Subject: [PATCH 118/130] . From e2891af010d330f5c1c650cc4216945c1693f875 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:03:46 +0800 Subject: [PATCH 119/130] . --- .github/workflows/run-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 72637819453..6135529fd7c 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -29,7 +29,7 @@ jobs: # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: - if: github.event.action == 'ready_for_review' || github.event.pull_request.draft != false + if: github.event.action == 'ready_for_review' || github.event.pull_request.draft == false uses: ./.github/workflows/run-mill-action.yml with: java-version: '11' @@ -37,7 +37,7 @@ jobs: populate_cache: true build-windows: - if: github.event.action == 'ready_for_review' || github.event.pull_request.draft != false + if: github.event.action == 'ready_for_review' || github.event.pull_request.draft == false uses: ./.github/workflows/run-mill-action.yml with: os: windows-latest @@ -46,7 +46,7 @@ jobs: populate_cache: true test-docs: - if: github.event.action == 'ready_for_review' || github.event.pull_request.draft != false + if: github.event.action == 'ready_for_review' || github.event.pull_request.draft == false runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From bd801e3a07db09c00978be2ee950ff4f7b3a00d5 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:03:46 +0800 Subject: [PATCH 120/130] . From 9cb9e7ffee8708444ab1aeefcf3c59abf5b184e8 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:03:54 +0800 Subject: [PATCH 121/130] . From aa2f4a1e48f2cd4acf0954573d02bf599e693cee Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:05:28 +0800 Subject: [PATCH 122/130] . --- .github/workflows/run-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 6135529fd7c..e56b61aa070 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -29,7 +29,7 @@ jobs: # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: - if: github.event.action == 'ready_for_review' || github.event.pull_request.draft == false + if: (github.event.action == 'ready_for_review') || (github.event.pull_request.draft == false) uses: ./.github/workflows/run-mill-action.yml with: java-version: '11' @@ -37,7 +37,7 @@ jobs: populate_cache: true build-windows: - if: github.event.action == 'ready_for_review' || github.event.pull_request.draft == false + if: (github.event.action == 'ready_for_review') || (github.event.pull_request.draft == false) uses: ./.github/workflows/run-mill-action.yml with: os: windows-latest @@ -46,7 +46,7 @@ jobs: populate_cache: true test-docs: - if: github.event.action == 'ready_for_review' || github.event.pull_request.draft == false + if: (github.event.action == 'ready_for_review') || (github.event.pull_request.draft == false) runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From eea45e65ef2723cd20319a2e795123857027a8e2 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:05:28 +0800 Subject: [PATCH 123/130] . From ed1dba927edb76191bcf8e25ffe3da5f42426660 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:05:35 +0800 Subject: [PATCH 124/130] . From fbba493a15217216037052df85d4a4ac41486ce5 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:27:46 +0800 Subject: [PATCH 125/130] . From 50fb8e4c4f0daf7910875511241e0a8d8c83e0b1 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:27:46 +0800 Subject: [PATCH 126/130] . From d820fe4c717119cbfcf19c310ca55ab59709a16a Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:27:54 +0800 Subject: [PATCH 127/130] . From 8910d3ef035c05f0515ca340d92f39313dfb237a Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:55:29 +0800 Subject: [PATCH 128/130] . From 2bdbf248fecfb030169300d0266f84f3a5201e93 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:55:29 +0800 Subject: [PATCH 129/130] . From 230e40ad0c33f8f8cee0ed03d37060e988a68724 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:55:36 +0800 Subject: [PATCH 130/130] .