-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Codebase #10
Labels
Comments
bits2zbytes
added a commit
to bits2zbytes/adaboost
that referenced
this issue
Mar 19, 2020
bits2zbytes
added a commit
to bits2zbytes/adaboost
that referenced
this issue
Mar 19, 2020
bits2zbytes
added a commit
to bits2zbytes/adaboost
that referenced
this issue
Mar 19, 2020
Hello, can me and my teammate riddhi99 also try contributing to this current open issue? |
Is this issue still open? |
Yes. @sreshu |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the problem
Currently the code base has mixed up CUDA kernels with C++ class and the API is too confusing. Some changes are to be made summarised in the following points,
Remove
fill
method from bothMatrix
andVector
classes - The first phase of refactoring should include removingfill
method from both of these classes and their GPU counter parts and shifting it tooperations
module. This will avoid kernel calls inside class methods and the APIs forMatrix
andVector
will be unambiguous.Shift
product
andmultiply
functions tooperations
module - The reason for doing this are similar to the above.Discuss API for using streams i.e., working on Using non-default streams in CUDA #2. Currently, methods like,
Vector.fill
decipher from theblock_size
whether to use GPU or not. Instead separate functions should be used for GPU and CPU with clean APIs.Example of the problem
References/Other comments
The text was updated successfully, but these errors were encountered: