Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Codebase #10

Open
2 of 3 tasks
czgdp1807 opened this issue Mar 12, 2020 · 4 comments
Open
2 of 3 tasks

Refactoring Codebase #10

czgdp1807 opened this issue Mar 12, 2020 · 4 comments
Labels
core cuda design help wanted Extra attention is needed

Comments

@czgdp1807
Copy link
Member

czgdp1807 commented Mar 12, 2020

Description of the problem

Currently the code base has mixed up CUDA kernels with C++ class and the API is too confusing. Some changes are to be made summarised in the following points,

  • Remove fill method from both Matrix and Vector classes - The first phase of refactoring should include removing fill method from both of these classes and their GPU counter parts and shifting it to operations module. This will avoid kernel calls inside class methods and the APIs for Matrix and Vector will be unambiguous.

  • Shift product and multiply functions to operations module - The reason for doing this are similar to the above.

  • Discuss API for using streams i.e., working on Using non-default streams in CUDA #2. Currently, methods like, Vector.fill decipher from the block_size whether to use GPU or not. Instead separate functions should be used for GPU and CPU with clean APIs.

Example of the problem

References/Other comments

@purva98
Copy link

purva98 commented Apr 5, 2020

Hello, can me and my teammate riddhi99 also try contributing to this current open issue?

@czgdp1807
Copy link
Member Author

@purva98 There is an open PR already working on this issue. See, #13

@sreshu
Copy link

sreshu commented Jun 18, 2020

Is this issue still open?

@czgdp1807
Copy link
Member Author

Yes. @sreshu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core cuda design help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants