Removing unnecessary lines from .travis.yml and fixing CMakeLists.txt

[czgdp1807]

Description of the problem

1. The following line is not needed,

   BNN/.travis.yml

   Line 13 in d21065c

   - ls -a

2. The following should use 1.10.0 release,

   BNN/CMakeLists.txt

   Lines 23 to 31 in d21065c

   	if(INSTALL_GOOGLETEST AND BUILD_TESTS)
   	include(${CMAKE_ROOT}/Modules/ExternalProject.cmake)
   	ExternalProject_Add(googletest
   	GIT_REPOSITORY https://github.com/google/googletest
   	GIT_TAG master
   	SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/googletest-src"
   	BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/googletest-build"
   	TEST_COMMAND "")
   	endif()

Example of the problem

References/Other comments

[yaswanth2802]

can 1 work on this issue @czgdp1807

[czgdp1807]

Sure.

[yaswanth2802]

@czgdp1807 do we need to remove the lines from 23 to 31 in CMakeLists.txt and change the version to 1.10.0 if this is right can you tell me where we can change the version because I am unable to find the src file for changing the version

[czgdp1807]

No. We have to keep 23 to 31 in CMakeLists.txt. As of now Google test's master branch is used (see the URL). We need to change it to use 1.10.0. The line to be removed 13 from .travis.yml.

[yaswanth2802]

I have changed the .travis.yml, and I have another doubt currently I am participating as a student in Kwoc 2022 so if I am changing the or contributing it will be counted right because there are no labels like Kwoc2022 like that.

[czgdp1807]

I have another doubt currently I am participating as a student in Kwoc 2022 so if I am changing the or contributing it will be counted right because there are no labels like Kwoc2022 like that.

AFAIK, contributions should be counted towards KWoC automatically. Though please ask the organisers for a clearer answer.

[yaswanth2802]

No. We have to keep 23 to 31 in CMakeLists.txt. As of now Google test's master branch is used (see the URL). We need to change it to use 1.10.0. The line to be removed 13 from .travis.yml.

as of now, the available version is 1.11.0 but we need to change it to 1.10.0. if this is right can you tell me if we can use this command https://github.com/google/googletest/archive/release-1.10.0.tar.gz then it will work or not in place of https://github.com/google/googletest

[czgdp1807]

Try changing the GIT_TAG to v1.10.x from master. See if it works on your system.

[yaswanth2802]

sir how to cheak the working of this in our system

[czgdp1807]

Try the following steps (assuming you are currently in BNN directory),

1. cd ../BNN
2. mkdir build-bnn
3. cd build-bnn
4. cmake -DBUILD_TESTS=ON -DINSTALL_GOOGLETEST=ON ../BNN
5. make
6. ./bin/test_core (it should pass)

Install cmake, g++ before executing the above commands.

[yaswanth2802]

i am getting error while performing the 4th step sir

[czgdp1807]

Please copy and post the error here.