5 second skip animation not visible

[xeophyte]

⚬ BUG: 5 second skip animation not visible
⚬ HOW: Open YT video and press arrow key to skip.
⚬ ImprovedTube Version: 4.704

/ ⚬ Context: "Hide 5 second skip animation" disabled
/ ⚬ Expected /preferred behavior: 5 second skip animation visible
⚬ Browser: Vivaldi | 6.6.3265.3
⚬ Settings:
improvedtube.json

[raszpl]

I didnt even notice any animations before, you mean those two circles?
They were showing for me at the start, "Hide 5 second skip animation" seems to have disabled them, turning off "Hide 5 second skip animation" doesnt bring it back.
There is just one little problem. "Hide 5 second skip animation" doesnt look like its implemented at all, it doesnt do anything:
https://github.com/search?q=repo%3Acode-charity%2Fyoutube+player_hide_skip_overlay&type=code

well, it doesnt do anything directly, it was hiding here

youtube/js&css/extension/www.youtube.com/appearance/player/player.css

Lines 559 to 562 in b412f2d

	html[it-player-hide-skip-overlay=true] .ytp-doubletap-ui, .ytp-doubletap-ui-legacy
	{
	visibility: hidden;
	}

[xeophyte]

[raszpl]

Yes I found it in the end, patch fixing the issue is already in a pull request ready to be merged.
To fix it in the mean time open improvetube menu, right click on it and pick Inspect, to go console and execute
satus.storage.remove("player_hide_skip_overlay")

[ImprovedTube]

well, it doesn't do anything directly, it was hiding here

we can sync and or document the naming convention.

[raszpl]

well, it doesn't do anything directly, it was hiding here

we can sync and or document the naming convention.

some way of marking options that are used by CSS is a good idea. would make #2197 easier without manually building a list of what to inject into
something like a config_variable_name_css postfix?

[ImprovedTube]

hi! @raszpl

https://github.com/search?q=repo%3Acode-charity%2Fyoutube+player_hide_skip_overlay&type=code

just meant to answer, that the JS names could avoid _'s, so that the CSS name could also appear then when you search 😅

• or we could / should allow ublock rules already! ( Shouldnt we fork ublock origin already & crowdsource rules?  #2216 hi! :) @letsblockit crowd-fixes#1 )

---

didn't mean to abandon #2197. At least was going to edit it later. Even if disabling the whitelist, thats easy than rewriting the rest. And that would keep the correct author in the commit history.

[raszpl]

just meant to answer, that the JS names could avoid _'s, so that the CSS name could also appear then when you search 😅

there is already precedence to using_

youtube/js&css/web-accessible/www.youtube.com/shortcuts.js

Lines 163 to 171 in 862f8c1

	for (var name in this.storage) {
	if (name.indexOf('shortcut_') === 0) {
	if (this.isset(this.storage[name]) && this.storage[name] !== false) {
	try {
	var key = 'shortcut' + (name.replace(/_?shortcut_?/g, '').replace(/\_/g, '-')).split('-').map(function (element, index) {
	return element[0].toUpperCase() + element.slice(1);
	}).join('');
	storage[key] = this.storage[name];