Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/server/storage_api/storage_api_test: TestAdminDecommissionedOperations failed #137958

Open
cockroach-teamcity opened this issue Dec 23, 2024 · 1 comment
Labels
branch-release-24.1.10-rc C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 23, 2024

pkg/server/storage_api/storage_api_test.TestAdminDecommissionedOperations failed with artifacts on release-24.1.10-rc @ 13ae7a1798fe3421755831be8459ae9d48f771c4:

=== RUN   TestAdminDecommissionedOperations
    test_log_scope.go:165: test logs captured to: /artifacts/tmp/_tmp/e3bcaec89ce770232ceace15c7e08c46/logTestAdminDecommissionedOperations632176863
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:88: cluster virtualization disabled due to issue: #81590 (expected label: C-bug)

pkg/server/storage_api/storage_api_test_test/pkg/server/storage_api/decommission_test.go:814: (TestAdminDecommissionedOperations)
	NOTICE: .NodeID() called via implicit interface StorageLayerInterface;
HINT: consider using .StorageLayer().NodeID() instead.

pkg/server/storage_api/storage_api_test_test/pkg/server/storage_api/decommission_test.go:822: (TestAdminDecommissionedOperations)
	NOTICE: .NodeID() called via implicit interface StorageLayerInterface;
HINT: consider using .StorageLayer().NodeID() instead.

pkg/server/storage_api/storage_api_test_test/pkg/server/storage_api/decommission_test.go:828: (TestAdminDecommissionedOperations.func1)
	NOTICE: .DB() called via implicit interface ApplicationLayerInterface;
HINT: consider using .ApplicationLayer().DB() instead.
TIP: consider replacing the test server initialization from:
    ts, ... := serverutils.StartServer(t, ...)
    defer ts.Stopper().Stop(...)
to:
    srv, ... := serverutils.StartServer(t, ...)
    defer srv.Stopper().Stop(...)
    ts := srv.ApplicationLayer()

See also: https://go.crdb.dev/p/testserver-and-cluster-virtualization
    decommission_test.go:972: -- test log scope end --
--- FAIL: TestAdminDecommissionedOperations (3.21s)
=== RUN   TestAdminDecommissionedOperations/Drain
    decommission_test.go:967: 
        	Error Trace:	pkg/server/storage_api/storage_api_test_test/pkg/server/storage_api/decommission_test.go:967
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:70
        	            				github.com/cockroachdb/cockroach/pkg/util/retry/retry.go:208
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:76
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:55
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:37
        	            				pkg/server/storage_api/storage_api_test_test/pkg/server/storage_api/decommission_test.go:949
        	Error:      	Not equal: 
        	            	expected: 0x7
        	            	actual  : 0x2
        	Test:       	TestAdminDecommissionedOperations/Drain
        	Messages:   	rpc error: code = Unknown desc = some sessions did not respond to cancellation within 1s
    --- FAIL: TestAdminDecommissionedOperations/Drain (1.01s)
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

/cc @cockroachdb/unowned

This test on roachdash | Improve this report!

Jira issue: CRDB-45817

@cockroach-teamcity cockroach-teamcity added branch-release-24.1.10-rc C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Dec 23, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Dec 23, 2024
@cockroach-teamcity
Copy link
Member Author

pkg/server/storage_api/storage_api_test.TestAdminDecommissionedOperations failed on release-24.1.10-rc @ 13ae7a1798fe3421755831be8459ae9d48f771c4:

=== RUN   TestAdminDecommissionedOperations
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestAdminDecommissionedOperations750579739
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:88: cluster virtualization disabled due to issue: #81590 (expected label: C-bug)

pkg/server/storage_api/storage_api_test_test/pkg/server/storage_api/decommission_test.go:814: (TestAdminDecommissionedOperations)
	NOTICE: .NodeID() called via implicit interface StorageLayerInterface;
HINT: consider using .StorageLayer().NodeID() instead.

pkg/server/storage_api/storage_api_test_test/pkg/server/storage_api/decommission_test.go:822: (TestAdminDecommissionedOperations)
	NOTICE: .NodeID() called via implicit interface StorageLayerInterface;
HINT: consider using .StorageLayer().NodeID() instead.

pkg/server/storage_api/storage_api_test_test/pkg/server/storage_api/decommission_test.go:828: (TestAdminDecommissionedOperations.func1)
	NOTICE: .DB() called via implicit interface ApplicationLayerInterface;
HINT: consider using .ApplicationLayer().DB() instead.
TIP: consider replacing the test server initialization from:
    ts, ... := serverutils.StartServer(t, ...)
    defer ts.Stopper().Stop(...)
to:
    srv, ... := serverutils.StartServer(t, ...)
    defer srv.Stopper().Stop(...)
    ts := srv.ApplicationLayer()

See also: https://go.crdb.dev/p/testserver-and-cluster-virtualization
    decommission_test.go:972: -- test log scope end --
test logs left over in: outputs.zip/logTestAdminDecommissionedOperations750579739
--- FAIL: TestAdminDecommissionedOperations (2.75s)
=== RUN   TestAdminDecommissionedOperations/Drain
    decommission_test.go:967: 
        	Error Trace:	pkg/server/storage_api/storage_api_test_test/pkg/server/storage_api/decommission_test.go:967
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:70
        	            				github.com/cockroachdb/cockroach/pkg/util/retry/retry.go:208
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:76
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:55
        	            				github.com/cockroachdb/cockroach/pkg/testutils/soon.go:37
        	            				pkg/server/storage_api/storage_api_test_test/pkg/server/storage_api/decommission_test.go:949
        	Error:      	Not equal: 
        	            	expected: 0x7
        	            	actual  : 0x2
        	Test:       	TestAdminDecommissionedOperations/Drain
        	Messages:   	rpc error: code = Unknown desc = some sessions did not respond to cancellation within 1s
    --- FAIL: TestAdminDecommissionedOperations/Drain (1.00s)

Parameters:

  • attempt=1
  • run=24
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-release-24.1.10-rc C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Development

No branches or pull requests

1 participant