Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaking change detection #46

Open
phlax opened this issue Jun 23, 2022 · 0 comments
Open

Add breaking change detection #46

phlax opened this issue Jun 23, 2022 · 0 comments

Comments

@phlax
Copy link
Member

phlax commented Jun 23, 2022

following up on slack conversation about possibility of using buf breaking change detection

the context was a discussion about moving Envoy's protos to the xds repo and whether we would be able to avoid running all of Envoy's CI in order to detect breaking changes

i dont have a concrete answer to that yet, im just getting a feel of how buf works, but i think probably the best first step is to add the buf dependency, and some initial linting (#45 )

from there i would suggest we look at if/how it could be used with existing xds protos

my initial (limted) understanding is that it works by checking local protos against published ones - it may not do what we need in terms of above goals - but is probably still quite useful even if it doesnt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant