Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable or rewrite the flacky test #86

Open
vincenzopalazzo opened this issue May 4, 2023 · 3 comments
Open

disable or rewrite the flacky test #86

vincenzopalazzo opened this issue May 4, 2023 · 3 comments

Comments

@vincenzopalazzo
Copy link
Member

Recent integration testing show that there is something wrong with this test, so we should diable it or fix it

jrcplightning_1  |   Test testCommandConnectAndCloseOne FAILED
jrcplightning_1  | 
jrcplightning_1  |   junit.framework.AssertionFailedError: Error when running the command FUNDCHANNEL.
jrcplightning_1  |   Error inside command with error code: 304
jrcplightning_1  |    Message: Still syncing with bitcoin network 
jrcplightning_1  |    listfunds -> {"outputs":
@theborakompanioni
Copy link
Collaborator

Hmm.. it seems that this is always skipped on my end

jrcplightning_1  |   Test testCommandConnectAndCloseOne SKIPPED

Also, I cannot seem to run the test multiple times:

jrcplightning_1  | run c-lightning
jrcplightning_1  | bitcoind has gone backwards from 6228 to 300 blocks!
jrcplightning_1  | bitcoind has gone backwards from 6927 to 300 blocks!
jrcplightning_1  | lightning-cli: Connecting to 'lightning-rpc': Connection refused
jrcplightning_1  | lightning-cli: Connecting to 'lightning-rpc': Connection refused
jrcplightning_1  | lightning-cli: Connecting to 'lightning-rpc': Connection refused
jrcplightning_1  | error code: -5
jrcplightning_1  | error message:
jrcplightning_1  | Invalid Bitcoin address: 
jrcplightning_1  | lightning-cli: Connecting to 'lightning-rpc': Connection refused

Always need to start clean for the tests to run through successfully.
How do you do it?

@vincenzopalazzo
Copy link
Member Author

Just this docker-compose up --exit-code-from jrcplightning

Then it will create some directory in the sandbox regarding the regtest that need to be deleted manually unfortunately, but all the testing is managed with docker

@vincenzopalazzo
Copy link
Member Author

btw I guess we can put an @Ignore on top of the test and ignore it.

The test are written badly unfortunatly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants