Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception Refactoring #5

Open
vincenzopalazzo opened this issue Sep 6, 2020 · 4 comments
Open

Exception Refactoring #5

vincenzopalazzo opened this issue Sep 6, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers refactoring refactoring code
Milestone

Comments

@vincenzopalazzo
Copy link
Member

The exception inside the library needs a little refactoring and more improvements.

P.S: The exception inside the plugin need to use the log to print the message to lightningd console or debug file

@vincenzopalazzo vincenzopalazzo added enhancement New feature or request good first issue Good for newcomers labels Sep 6, 2020
@vincenzopalazzo vincenzopalazzo added this to the v0.3.0 milestone Oct 14, 2021
@Ejaz29
Copy link

Ejaz29 commented Oct 17, 2021

hi @vincenzopalazzo
I am beginner to opensource but I would also like to contribute to the issue if it is open.
can you help me with it?

@vincenzopalazzo
Copy link
Member Author

More than welcome @Ejaz29,

Basical the library now has 3 exception type under different package, and the refactoring it is like the following:

Basicaly you need to walk in the code and see if these rules are respected.

@Ejaz29
Copy link

Ejaz29 commented Oct 17, 2021

ok but do I have to add anything or change anything @vincenzopalazzo

@vincenzopalazzo
Copy link
Member Author

ok but do I have to add anything or change anything @vincenzopalazzo

Not sure what you mean, but there is something that requires change, sure you need to propose some change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers refactoring refactoring code
Projects
None yet
Development

No branches or pull requests

2 participants