Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace DLL build script with Webpack build script (help us test plugin localization) #186

Open
jjroelofs opened this issue Sep 3, 2024 · 1 comment
Labels
pending:feedback This issue is blocked by necessary feedback. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@jjroelofs
Copy link

jjroelofs commented Sep 3, 2024

📝 Provide a description of the improvement

Currently, @ckeditor/ckeditor5-package-tools includes a legacy DLL build script intended for testing custom CKEditor 5 packages. However, this script relies on an outdated build system. The goal is to replace the legacy DLL build script with a modern Webpack build script, which will improve maintainability and compatibility with current development practices.

For us this is important because the DLL build process does not support multilingual builds, and we are developing a package with multilingual support and want need to create proper test scenarios for it. Being able to build the whole build with an RTL language is currently not possible with the DLL system as far as I can tell.

If there are any workarounds for this, would be great if you can share! I imagine you are testing your plugin localization in some way when developing your own plugins, as core team.

📃 Other details

  • Node: [Your Node.js version]
  • Npm / Yarn: [Your Npm or Yarn version]
  • First affected version: [The first version where this issue was noticed]

If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@jjroelofs jjroelofs added the type:improvement This issue reports a possible enhancement of an existing feature. label Sep 3, 2024
@filipsobol
Copy link
Member

filipsobol commented Sep 24, 2024

When we released the new installation methods in ckeditor5 v42.0.0, we also released an updated version of the package generator. Now, when you run npx ckeditor5-package-generator @<SCOPE>/ckeditor5-<PLUGIN_NAME>, you will be asked which installation methods of CKEditor 5 you want to support. You'll have two options:

  • Current, which only supports new installation methods.
  • Legacy, which supports new installation methods and other legacy methods, including DLLs.

If you migrated your main project to v42.0.0 and new installation methods, you can also migrate your plugin to use the new installation methods and drop support for DLLs and other legacy methods.

You can find more information in the Migrating to new installation methods and Migrating custom plugins guides.

@filipsobol filipsobol added the pending:feedback This issue is blocked by necessary feedback. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending:feedback This issue is blocked by necessary feedback. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants