Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve multiroot support #176

Open
mlewand opened this issue Aug 10, 2023 · 2 comments
Open

Improve multiroot support #176

mlewand opened this issue Aug 10, 2023 · 2 comments

Comments

@mlewand
Copy link
Contributor

mlewand commented Aug 10, 2023

  • Add handling for detached (removed) roots.
    • Currently there's no difference.
  • Set data dialog should allow to chose which root will receive data change.
@mlewand
Copy link
Contributor Author

mlewand commented Aug 10, 2023

As of implementation, we removed detached root in the initial solution.

However @scofalik pointed out that it could be useful in some cases to actually be able to see detached roots (to make sure that what you did works as expected and that the data there is emptied correctly).

Wondering what is the best solution for that. Following comes to my mind:

  • Just append a " (detached)" text to it's name and sort them to be at the end of results (but before graveyard).
  • Add opt-in flag setting to toggle visibility of detached roots.

I like the first solution more as it's much cheaper to implement and has 0 learning curve.

@scofalik
Copy link

+1 for "just append".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants