Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run karma tests with local ckeditor-dev package #37

Open
f1ames opened this issue May 6, 2019 · 1 comment
Open

Run karma tests with local ckeditor-dev package #37

f1ames opened this issue May 6, 2019 · 1 comment
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.

Comments

@f1ames
Copy link
Contributor

f1ames commented May 6, 2019

The karma.conf.js file now uses CDN to load ckeditor package for tests. It makes sense in many cases because the integration will use already released packages, however it makes it unable to test integration with some local changes in ckeditor-dev package.

We should enable testing with local ckeditor-dev package.

Related to ckeditor/ckeditor4-angular#8.
@f1ames
Copy link
Contributor Author

f1ames commented May 10, 2019

See further discussion in ckeditor/ckeditor4-angular#8 starting from ckeditor/ckeditor4-angular#8 (comment).

@jacekbogdanski jacekbogdanski added status:confirmed An issue confirmed by the development team. type:feature A feature request. and removed confirmed labels Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@f1ames @jacekbogdanski