Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp unit tests structure #210

Open
Dumluregn opened this issue Jul 16, 2021 · 0 comments
Open

Revamp unit tests structure #210

Dumluregn opened this issue Jul 16, 2021 · 0 comments
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).

Comments

@Dumluregn
Copy link
Collaborator

Are you reporting a feature request or a bug?

Task

Details

See #202 (review):

Besides I have a few thoughts regarding tests of ckeditor4-angular in general. There is no clear distinction between unit tests and E2E tests. The only true unit tests are here. Other test files such as demo-form.component.spec.ts and simple-usage.component.spec.ts test main component indirectly and resemble E2E scenarios. On top of that we have app.e2e-spec.ts. This is quite confusing to me.
@Dumluregn Dumluregn added status:confirmed An issue confirmed by the development team. size:M type:task Any other issue (refactoring, typo fix, etc). labels Jul 16, 2021
@Dumluregn Dumluregn mentioned this issue Jul 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacekbogdanski @Dumluregn