Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ECS tries to pull a non-existent image on certain slices #259

Open
dtsai-czi opened this issue Apr 26, 2022 · 1 comment
Open

fix: ECS tries to pull a non-existent image on certain slices #259

dtsai-czi opened this issue Apr 26, 2022 · 1 comment
Assignees

Comments

@dtsai-czi
Copy link
Contributor

Related to #238--what is the intended behavior for when slices are built, tagged, and pushed? If none of the services named in the integration secret belong to the profile defined by the slice, it seems that ECS looks to pull an image for a tag that doesn't get pushed and consequently hangs. Would it make sense to just push all services defined in docker-compose just so ECS at least finds something and doesn't hang?

@edulop91
Copy link
Contributor

There is an implicit/undocumented assumption that only services with a build key are actually built and assumed part of a "remote/ecs service". Any docker-compose service without a build key is assumed to be only useful for local development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants