Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require CMake 3.5 #112

Open
Tachi107 opened this issue Oct 5, 2022 · 1 comment
Open

Require CMake 3.5 #112

Tachi107 opened this issue Oct 5, 2022 · 1 comment

Comments

@Tachi107
Copy link

Tachi107 commented Oct 5, 2022

As cmake-init requires policy CMP0063, it already effectively requires CMake 3.3. The oldest CMake version available in "mainstream" distributions is CMake 3.5, shipped with Ubuntu 16.04 (almost 7 years old, LTS support ended in 2021, in Extended security maintenance until 2026).

Unless there's a reason to require an older CMake version, I don't see why not to upgrade.

@scheibel
Copy link
Member

scheibel commented Feb 5, 2023

Thanks for the pointer.
I created a follow-up issue to discuss the actual desired minimum version of CMake in #114.

Please note, that our use of CMP0063 will not require the use of CMake 3.3 as we implemented an additional policy existence check:

function(set_policy POL VAL)
    if(POLICY ${POL})
        cmake_policy(SET ${POL} ${VAL})
    endif()
endfunction(set_policy)

In the case of older CMake versions, where a policy is not yet defined, this will result in the OLD behavior instead of the parameter value, which should be manageable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants