Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support buffering by bytes rather than number of lines #4

Open
ccampo133 opened this issue Aug 21, 2024 · 0 comments
Open

Support buffering by bytes rather than number of lines #4

ccampo133 opened this issue Aug 21, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ccampo133
Copy link
Owner

Currently the message buffer size represents the number of log messages (lines) and not their individual sizes. This is desirable in many (most?) cases, however this may not be so useful when log messages are extremely large, as it could result in log2fluent consuming lots of memory, or worse, stalling, while it attempts to read the long lines into memory.

The buffering strategy should be configurable by the user via some flag(s), to be either line or byte based. This will require a different implementation of the reader goroutine.

@ccampo133 ccampo133 added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant