You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a system that transfers items from a furnace output slot to a barrel. When the barrel is full items will disappear instead of staying in the furnace.
The issue is not specific to barrels, it also happens with chests
Steps to recreate:
Create at wired network containing a furnace, a computer and a barrel
Other observations:
If there is some but not enough space in the target inventory it will fill the inventory and the remaining items will disappear.
The pushItems function returns the amount of items successfully moved, the disappeared items are not counted.
If a limit is set in the pushItems function only the amount of items specified will disappear.
The text was updated successfully, but these errors were encountered:
This was happening because the output slot of a furnace is protected
from all insertions. We were greedily extracting items at the beginning
of the transfer and couldn't place the remainder back into the protected
slot. Instead, simulate the transaction first, count how many items
successfully transfer, then actually mutate the inventories by that
amount. The ItemStorage wrappers already supported simulating
transactions, so I just exposed the option in InventoryUtil.
Also, because it's likely there's still some edge cases where things
will go wrong (especially in the presence of modded blocks), I added
some detailed logging in the case that we detect that items have been
lost.
Fixescc-tweaked#122
Minecraft Version
1.18.x
Version
1.100.8
Details
I have a system that transfers items from a furnace output slot to a barrel. When the barrel is full items will disappear instead of staying in the furnace.
The issue is not specific to barrels, it also happens with chests
Steps to recreate:
Other observations:
If there is some but not enough space in the target inventory it will fill the inventory and the remaining items will disappear.
The pushItems function returns the amount of items successfully moved, the disappeared items are not counted.
If a limit is set in the pushItems function only the amount of items specified will disappear.
The text was updated successfully, but these errors were encountered: