Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Seaport tests #6

Open
5 tasks
tekkac opened this issue Apr 9, 2024 · 2 comments
Open
5 tasks

Port Seaport tests #6

tekkac opened this issue Apr 9, 2024 · 2 comments
Assignees
@saimeunt
Labels
enhancement New feature or request

Comments

@tekkac
Copy link
Contributor

tekkac commented Apr 9, 2024 •
edited
Loading

Description

Adapt and implement tests files below using Starknet Foundry in Cairo 2.6 from OpenSea's SeaPort implementation of Redeemables

  • test/ERC7498-GetAndUpdateCampaign.t.sol
  • test/ERC7498-MultiRedeem.t.sol
  • test/ERC7498-SimpleRedeem.t.sol
  • test/ERC7498-TraitRedemption.t.sol

Additional Information

[Medium - Cairo - Medium Priority]

Acceptance Criteria

  • Adapt and pass Solidity tests
@tekkac tekkac added the enhancement New feature or request label Apr 9, 2024
@thomas192
Copy link

thomas192 commented Apr 9, 2024 •
edited
Loading

Hey, can I take this one ? I have worked on similar issues 🙂

@saimeunt
Copy link
Contributor

saimeunt commented Apr 9, 2024

Hey I'd like to work on this one, I wrote the initial e2e tests as well as the implemention so I'll get this done quickly!

@Khyati729 Khyati729 added good first issue Good for newcomers ODHack labels Apr 10, 2024
@Khyati729 Khyati729 assigned thomas192 and unassigned thomas192 Apr 10, 2024
@Khyati729 Khyati729 removed good first issue Good for newcomers ODHack labels Apr 10, 2024
@saimeunt saimeunt mentioned this issue Jun 19, 2024
Merged
@Khyati729 Khyati729 reopened this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saimeunt saimeunt

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@saimeunt @thomas192 @tekkac @Khyati729