From 2688892b4bfc5ae05fba2007ac522d69b5a0bfea Mon Sep 17 00:00:00 2001
From: "maciej.lodygowski" <maciej.lodygowski@callstack.com>
Date: Mon, 7 Oct 2024 15:37:05 +0200
Subject: [PATCH 1/3] fix: new arch android interface

---
 example/package.json                                      | 2 +-
 .../reactnativecommunity/slider/ReactSliderManager.java   | 8 ++++----
 package/src/RNCSliderNativeComponent.ts                   | 7 ++++---
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/example/package.json b/example/package.json
index 19adefc5..c87fecfa 100644
--- a/example/package.json
+++ b/example/package.json
@@ -19,7 +19,7 @@
     "babel-preset-expo": "^9.2.0",
     "react": "18.2.0",
     "react-native": "0.73.5",
-    "react-native-pager-view": "^6.2.3",
+    "react-native-pager-view": "^6.4.1",
     "react-native-windows": "0.73.11"
   },
   "devDependencies": {
diff --git a/package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java b/package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
index 9be02a44..0240b725 100644
--- a/package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
+++ b/package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
@@ -125,12 +125,12 @@ public void setValue(ReactSlider view, float value) {
     ReactSliderManagerImpl.setValue(view, value);
   }
 
-  @ReactProp(name = "minimumValue", defaultFloat = 0f)
+  @ReactProp(name = "minimumValue", defaultDouble = 0f)
   public void setMinimumValue(ReactSlider view, double value) {
     ReactSliderManagerImpl.setMinimumValue(view, value);
   }
 
-  @ReactProp(name = "maximumValue", defaultFloat = 1f)
+  @ReactProp(name = "maximumValue", defaultDouble = 1f)
   public void setMaximumValue(ReactSlider view, double value) {
     ReactSliderManagerImpl.setMaximumValue(view, value);
   }
@@ -145,8 +145,8 @@ public void setUpperLimit(ReactSlider view, float value) {
     ReactSliderManagerImpl.setUpperLimit(view, value);
   }
 
-  @ReactProp(name = "step", defaultFloat = 0f)
-  public void setStep(ReactSlider view, float value) {
+  @ReactProp(name = "step", defaultDouble = 0f)
+  public void setStep(ReactSlider view, double value) {
     ReactSliderManagerImpl.setStep(view, value);
   }
 
diff --git a/package/src/RNCSliderNativeComponent.ts b/package/src/RNCSliderNativeComponent.ts
index cab4abfb..c63f8d5e 100644
--- a/package/src/RNCSliderNativeComponent.ts
+++ b/package/src/RNCSliderNativeComponent.ts
@@ -7,6 +7,7 @@ import type {
   WithDefault,
   DirectEventHandler,
   BubblingEventHandler,
+  Double,
 } from 'react-native/Libraries/Types/CodegenTypes';
 
 type Event = Readonly<{
@@ -23,15 +24,15 @@ export interface NativeProps extends ViewProps {
   tapToSeek?: WithDefault<boolean, false>;
   maximumTrackImage?: ImageSource;
   maximumTrackTintColor?: ColorValue;
-  maximumValue?: Float;
+  maximumValue?: Double;
   minimumTrackImage?: ImageSource;
   minimumTrackTintColor?: ColorValue;
-  minimumValue?: Float;
+  minimumValue?: Double;
   onChange?: BubblingEventHandler<Event>;
   onRNCSliderSlidingStart?: DirectEventHandler<Event>;
   onRNCSliderSlidingComplete?: DirectEventHandler<Event>;
   onRNCSliderValueChange?: BubblingEventHandler<Event>;
-  step?: Float;
+  step?: Double;
   testID?: string;
   thumbImage?: ImageSource;
   thumbTintColor?: ColorValue;

From 699e74887a5841e25dd76a46dcff6b6d1d9f9909 Mon Sep 17 00:00:00 2001
From: "maciej.lodygowski" <maciej.lodygowski@callstack.com>
Date: Tue, 8 Oct 2024 09:17:28 +0200
Subject: [PATCH 2/3] fix: height on android

---
 package/src/Slider.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/src/Slider.tsx b/package/src/Slider.tsx
index 45983ec4..f164b00a 100644
--- a/package/src/Slider.tsx
+++ b/package/src/Slider.tsx
@@ -232,7 +232,7 @@ const SliderComponent = (
 
   const defaultStyle =
     Platform.OS === 'ios' ? styles.defaultSlideriOS : styles.defaultSlider;
-  const sliderStyle = {zIndex: 1, width: width};
+  const sliderStyle = {zIndex: 1, width: width, height: 1};
   const style = [props.style, defaultStyle];
 
   const onValueChangeEvent = (event: Event) => {

From a9567cd894974d4a7364746583e3355b6084ca86 Mon Sep 17 00:00:00 2001
From: "maciej.lodygowski" <maciej.lodygowski@callstack.com>
Date: Tue, 8 Oct 2024 09:32:23 +0200
Subject: [PATCH 3/3] revert: fix android

---
 package/src/Slider.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/src/Slider.tsx b/package/src/Slider.tsx
index f164b00a..45983ec4 100644
--- a/package/src/Slider.tsx
+++ b/package/src/Slider.tsx
@@ -232,7 +232,7 @@ const SliderComponent = (
 
   const defaultStyle =
     Platform.OS === 'ios' ? styles.defaultSlideriOS : styles.defaultSlider;
-  const sliderStyle = {zIndex: 1, width: width, height: 1};
+  const sliderStyle = {zIndex: 1, width: width};
   const style = [props.style, defaultStyle];
 
   const onValueChangeEvent = (event: Event) => {