Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to achieve a reconnect delay in the client? #918

Open
jrmclaurin opened this issue Oct 2, 2024 · 5 comments
Open

How to achieve a reconnect delay in the client? #918

jrmclaurin opened this issue Oct 2, 2024 · 5 comments

Comments

@jrmclaurin
Copy link

The client currently appears to have no delay when attempting to reconnect to a broker. This can be especially problematic when the broker is running locally, since the failure happens very quickly, so you get a very fast rate of reconnect attempts.

The eventLoop poll() method warns "Don't block this while iterating." Does that mean it's always harmful to wait before re-polling, even immediately after a disconnect event is returned?

Would it be possible for the client to implement at least a reconnect delay, if not an exponential backoff, that would work even in cases where eventLoop.poll() is always called with no delay?

@jadamcrain
Copy link

jadamcrain commented Oct 5, 2024

This is even more problematic for production systems where the connection to the broker is over a low-latency LAN. You can flood the network with connection requests as the client requests a connection but the server immediately rejects them. It the case where the destination host is unreachable or does not respond, the OS itself implements a retry w/ back-off on the initial TCP SYN, but in the case of an active rejection, it's always required that user code implement a retry delay for client protocols.

If a PR would be considered to implement this behavior in the library, we'd consider implementing it. Just want to have buy-in from the maintainers that this is a valid use case to handle in the library itself. The way MqttOptions is implemented as a builder is nice because we could a parameter for reconnect delay without breaking semver.

@de-sh
Copy link
Member

de-sh commented Oct 5, 2024

Does that mean it's always harmful to wait before re-polling, even immediately after a disconnect event is returned?

That wasn't the intention of the comment. We merely wanted to convey that while connected the poll method must be called consistently to ensure the system progresses and doesn't get disconnected due to breach of keepalive timeout. Here is how we do this.

Would it be possible for the client to implement at least a reconnect delay, if not an exponential backoff, that would work even in cases where eventLoop.poll() is always called with no delay?

If a PR would be considered to implement this behavior in the library, we'd consider implementing it.

Thanks for the interest, but we feel it is a better practice to implement this outside of the library and keep it clean with regards to the MQTT standards. We would love to see examples though, and are willing to accept documentation improvements if that'd be something you could help us with!

@jadamcrain
Copy link

@de-sh Can you point me where in the MQTT standard it says the client must or must not implement a reconnect delay? This is functionality that every user developing a real-world system needs to implement MQTT robustly. An option could be defaulted to 0 (no delay) if you feel that's the default best behavior.

@de-sh
Copy link
Member

de-sh commented Oct 5, 2024

Can you point me where in the MQTT standard it says the client must or must not implement a reconnect delay?

There might be a misunderstanding here, I was also point out the same in my message. We should implement this outside of the library, but an example would be a starting point for anyone interested to get started.

@jadamcrain
Copy link

Thanks for clarifying @de-sh, I understand what you're saying now. We'll produce an example of what it takes to implement this outside the library currently, an we can continue the discussion from there as to whether it belongs inside the library or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants