From 1aca8c1b0ed4145cebf3431c59c07fd6302dcc0a Mon Sep 17 00:00:00 2001 From: Natalie Arellano Date: Mon, 27 Jan 2020 12:18:14 -0500 Subject: [PATCH] Bump default lifecycle version - Also bump default platform api version since lifecycle 0.6.0 implements a newer api. - Move const and make private - it is only used in acceptance tests. Signed-off-by: Natalie Arellano --- acceptance/acceptance_test.go | 4 +++- acceptance/testdata/pack_fixtures/report_output.txt | 2 +- internal/builder/lifecycle.go | 3 +-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/acceptance/acceptance_test.go b/acceptance/acceptance_test.go index 600c1e74f..272bc5199 100644 --- a/acceptance/acceptance_test.go +++ b/acceptance/acceptance_test.go @@ -51,6 +51,8 @@ const ( runImage = "pack-test/run" buildImage = "pack-test/build" + + defaultPlatformAPIVersion = "0.2" ) var ( @@ -110,7 +112,7 @@ func TestAcceptance(t *testing.T) { }, API: builder.LifecycleAPI{ BuildpackVersion: api.MustParse(builder.DefaultBuildpackAPIVersion), - PlatformVersion: api.MustParse(builder.DefaultPlatformAPIVersion), + PlatformVersion: api.MustParse(defaultPlatformAPIVersion), }, } lifecyclePath := os.Getenv(envLifecyclePath) diff --git a/acceptance/testdata/pack_fixtures/report_output.txt b/acceptance/testdata/pack_fixtures/report_output.txt index 9f7adb203..1dad75f47 100644 --- a/acceptance/testdata/pack_fixtures/report_output.txt +++ b/acceptance/testdata/pack_fixtures/report_output.txt @@ -2,7 +2,7 @@ Pack: Version: {{ .Version }} OS/Arch: {{ .OS }}/{{ .Arch }} -Default Lifecycle Version: 0.5.0 +Default Lifecycle Version: 0.6.0 Config: default-builder-image = "{{ .DefaultBuilder }}" diff --git a/internal/builder/lifecycle.go b/internal/builder/lifecycle.go index 20a21b7b5..808a97131 100644 --- a/internal/builder/lifecycle.go +++ b/internal/builder/lifecycle.go @@ -15,9 +15,8 @@ import ( ) const ( - DefaultLifecycleVersion = "0.5.0" + DefaultLifecycleVersion = "0.6.0" DefaultBuildpackAPIVersion = "0.2" - DefaultPlatformAPIVersion = "0.1" ) type Blob interface {