Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md is Innacurate #22

Open
bradharms opened this issue Dec 28, 2020 · 1 comment
Open

README.md is Innacurate #22

bradharms opened this issue Dec 28, 2020 · 1 comment

Comments

@bradharms
Copy link

https://github.com/browserify/path-browserify#install

The statement about Webpack including node.js polyfill code is no longer accurate as of Webpack 5, per this documentation. Some packages now require external polyfills like this one even when using Webpack if they are using the newest version.

@chefhoobajoob
Copy link

Separately from the webpack changes, it is not possible to run npm install path-browserify and expect this require statement to work:

var path = require('path')

...because there is no module entry named path in node_modules after running npm install path-browserify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants