Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistaken string == equality comparison in GencodeFunctotation.java #8385

Open
jamesemery opened this issue Jun 26, 2023 · 0 comments
Open

Comments

@jamesemery
Copy link
Collaborator

It was noticed while doing #8351 that the GencodeFunctotation.equals() method has the following line in it

if (geneTranscriptType != that.geneTranscriptType) return false; 

Unfortunately the geneTranscriptType is stored as a Sting and thus this should NOT be expected to succeed in almost any case. As it stands fixing this innocuous oversight seems to break several of the combinatorial funcotator tests and an integration test. Somebody should fix this behavior (easy) and validate that the test changes are within tolerable levels (hard).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant