Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadsContext class needs caching #4781

Open
droazen opened this issue May 17, 2018 · 2 comments
Open

ReadsContext class needs caching #4781

droazen opened this issue May 17, 2018 · 2 comments

Comments

@droazen
Copy link
Collaborator

droazen commented May 17, 2018

Now that we have important VariantWalker tools that use reads as a side input (such as @lucidtronix 's CNNScoreVariants), we need to add caching to ReadsContext for good performance on nearby reads queries during a traversal.

The caching should be modeled after the existing caching in FeatureContext as implemented in the FeatureCache class, but it should include the ability to cache "around" the current locus, rather than just ahead of it as in FeatureCache. Ideally, the tool itself should be able to configure the default caching behavior via arguments to control bases to cache before and after current locus.

@droazen
Copy link
Collaborator Author

droazen commented May 17, 2018

For @cmnbroad (who has already started on the implementation, I believe)

@droazen
Copy link
Collaborator Author

droazen commented Feb 4, 2019

In review here: #4902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants