Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IfMatch and IfNoneMatch to S3Transfer.ALLOWED_UPLOAD_ARGS #4366

Open
2 tasks
rittneje opened this issue Dec 4, 2024 · 4 comments
Open
2 tasks

add IfMatch and IfNoneMatch to S3Transfer.ALLOWED_UPLOAD_ARGS #4366

rittneje opened this issue Dec 4, 2024 · 4 comments
Assignees
Labels
feature-request This issue requests a feature. p3 This is a minor priority issue response-requested Waiting on additional information or feedback. s3

Comments

@rittneje
Copy link

rittneje commented Dec 4, 2024

Describe the feature

put_object and complete_multipart_upload both accept optional args IfMatch and IfNoneMatch. However, there is no way to currently pass these to upload_file since these parameters are missing from S3Transfer.ALLOWED_UPLOAD_ARGS.

Use Case

They need to be there so we can for example enforce that IfNoneMatch: "*" was specified to prevent overwriting existing files when using upload_file, as described here.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

n/a

Environment details (OS name and version, etc.)

n/a

@rittneje rittneje added feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged. labels Dec 4, 2024
@adev-code adev-code self-assigned this Dec 9, 2024
@adev-code adev-code added investigating This issue is being investigated and/or work is in progress to resolve the issue. s3 p3 This is a minor priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Dec 9, 2024
@adev-code
Copy link

Hi @rittneje, thanks for reaching out and for bringing up the feature request. The team is aware of the feature request. Please refer to an SDK changelog (https://raw.githubusercontent.com/boto/boto3/develop/CHANGELOG.rst) for updates about this going forward. If you have any questions, please let us know. Thank you.

@adev-code adev-code added response-requested Waiting on additional information or feedback. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Dec 9, 2024
@rittneje
Copy link
Author

@adev-code Was the "response-requested" label added in error?

@fitz-vivodyne
Copy link

fitz-vivodyne commented Dec 13, 2024

Currently running into this issue with upload_fileobj

@fitz-vivodyne
Copy link

Looks like this needs to happen here in https://github.com/boto/s3transfer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requests a feature. p3 This is a minor priority issue response-requested Waiting on additional information or feedback. s3
Projects
None yet
Development

No branches or pull requests

3 participants