Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"allowpaging" not supported on setcontent in Bolt 5 #1251

Open
michaelborn opened this issue May 30, 2022 · 2 comments
Open

"allowpaging" not supported on setcontent in Bolt 5 #1251

michaelborn opened this issue May 30, 2022 · 2 comments

Comments

@michaelborn
Copy link
Contributor

It looks like this allowpaging option on the setcontent twig method was never implemented in Bolt 5. See PR: bolt/core#303

Screenshot from 2022-05-29 21-11-05

  1. Is there any plan to implement this? Is it necessary any more?
  2. This needs to be a documented incompat from Bolt 3 to Bolt 5.
@Spomsoree
Copy link

I don't think its needed anymore, I always receive a Pagerfanta-Object.
I'd need a disallowpaging now.

@michaelborn
Copy link
Contributor Author

I don't disagree, but I couldn't find anything about this in commits or issues on this repo... and certainly not in the docs. 😄

We probably just need a note in the Bolt 5 migration guide, but I'm not going to add that unless I know it's definitely not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelborn @Spomsoree