🐛 [BUG]: PAVICS_FQDN_PUBLIC should be used in many places instead of PAVICS_FQDN

[mishaschwartz]

Summary

In several locations across the code-base, the PAVICS_FQDN environment variable is used to display URLs that are user-facing. These should almost exclusively use the PAVICS_FQDN_PUBLIC variable instead.

⚠️
If #428 has been merged already, then the relevant variables have been changed to BIRDHOUSE_FQDN and BIRDHOUSE_FQDN_PUBLIC
⚠️

Details

The following are examples that have been flagged, there may be others as well and a full review of the code-base is needed where PAVICS_FQDN is used

birdhouse-deploy/birdhouse/components/magpie/magpie.ini.template

Line 31 in 8218166

magpie.url = https://${PAVICS_FQDN}/magpie

birdhouse-deploy/birdhouse/components/thredds/config/proxy/conf.extra-service.d/thredds.conf.template

Line 4 in 8218166

proxy_pass https://${PAVICS_FQDN}${TWITCHER_PROTECTED_PATH}/thredds/;

birdhouse-deploy/birdhouse/components/twitcher/twitcher.ini.template

Line 54 in 8218166

twitcher.url = https://${PAVICS_FQDN}/twitcher

birdhouse-deploy/birdhouse/components/twitcher/twitcher.ini.template

Line 68 in 8218166

magpie.url = https://${PAVICS_FQDN}/magpie

birdhouse-deploy/birdhouse/env.local.example

Lines 484 to 485 in 8218166

	# Homepage URL: https://${PAVICS_FQDN}
	# Authorization callback URL: https://${PAVICS_FQDN}/magpie/providers/github/signin

birdhouse-deploy/birdhouse/env.local.example

Line 536 in 8218166

#export RAVEN_GEO_URL="https://${PAVICS_FQDN}/geoserver/"

birdhouse-deploy/birdhouse/optional-components/README.rst

Line 11 in 8218166

So that the url ``https://<PAVICS_FQDN>/canarie/node/service/stats`` also return

birdhouse-deploy/birdhouse/optional-components/test-geoserver-secured-access/config/proxy/conf.d/test-geoserver-secured.conf.template

Line 2 in 06e9997

proxy_pass http://${BIRDHOUSE_FQDN}${TWITCHER_PROTECTED_PATH}/geoserver-secured/;

birdhouse-deploy/birdhouse/scripts/check-instance-ready

Line 22 in 8218166

curl --include --silent "https://${PAVICS_FQDN}/canarie/node/service/stats" | head

birdhouse-deploy/birdhouse/scripts/check-instance-ready

Line 31 in 8218166

curl --write-out '%{http_code}' --output /dev/null --silent "https://${PAVICS_FQDN}/canarie/node/service/stats" \

birdhouse-deploy/birdhouse/scripts/check-instance-ready

Line 44 in 8218166

curl --include --silent "https://${PAVICS_FQDN}/canarie/node/service/stats" | head

birdhouse-deploy/birdhouse/scripts/create-magpie-users

Line 83 in 8218166

MAGPIE_SERVER_URL="https://$PAVICS_FQDN/magpie"

Environment

Information	Value
Server/Platform URL	all
Version Tag/Commit	1.25.6+
Related issues/PR
Related components
Custom configuration

Concerned Organizations