Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformize .json files for .tsv's first column to be "<entity>_id" #69

Open
yarikoptic opened this issue Apr 11, 2024 · 0 comments
Open
Labels
consistency Aspect requiring special treatment/logic outside of generic common principles

Comments

@yarikoptic
Copy link
Contributor

yarikoptic commented Apr 11, 2024

We have participant_id in subjects.tsv, session_id in sessions.tsv, BUT we just ran into name being first column in _channels.tsv https://bids-specification.readthedocs.io/en/stable/modality-specific-files/intracranial-electroencephalography.html#channels-description-_channelstsv ... worth reviewing all .tsv files on that aspect.

edit 1: I even wonder if this should be taken as an opportunity to make all of them into just a value (as a generalization over index and label) or actual {entity} (e.g. subject or session) instead of {entity}_id which then includes {entity}- prefix (e.g. sub-01), which was always unclear to me on why to bother duplicating that obvious prefix.

But also here I am somewhat mixing up two different kinds of tabular files -- subjects sessions and samples correspond to entities. But we do not have entity "channel" for _channels.... so may be two issues in one

@yarikoptic yarikoptic added the consistency Aspect requiring special treatment/logic outside of generic common principles label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consistency Aspect requiring special treatment/logic outside of generic common principles
Projects
Status: In Progress
Development

No branches or pull requests

1 participant