Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement broadcastable for Samples #73

Open
omus opened this issue Mar 25, 2021 · 2 comments
Open

Implement broadcastable for Samples #73

omus opened this issue Mar 25, 2021 · 2 comments

Comments

@omus
Copy link
Member

omus commented Mar 25, 2021

By implementing broadcastable(::Samples) we can avoid having to use Ref when using Samples during a broadcast operation (e.g. channel.(Ref(eeg), rows)).

@ararslan
Copy link
Member

Don't we only avoid needing to use Ref if we define Samples to broadcast as a scalar? I think I would find it surprising as a user for it to broadcast as a scalar; I think I'd expect it'd broadcast like the type of its data field.

@jrevels
Copy link
Member

jrevels commented May 15, 2024

this is borderline superseded by #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants