Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port FLAC example to its own package #2

Open
SimonDanisch opened this issue Nov 11, 2019 · 5 comments
Open

port FLAC example to its own package #2

SimonDanisch opened this issue Nov 11, 2019 · 5 comments

Comments

@SimonDanisch
Copy link
Contributor

FLAC isn't installed on my pc which is why the tests fail... No biggy I guess, but should we think about using FLAC.jl, which is a binarybuilder for FLAC?
https://github.com/dmbates/FLAC.jl

@ararslan
Copy link
Member

It appears that FLAC.jl was purged from the General registry. (I forget what the conditions were for being purged, but a purge happened recently.) So we'd need to use something else, or just use the BuilderBuilder-built FLAC binaries ourselves.

@SimonDanisch
Copy link
Contributor Author

It is super old indeed -.- But maybe one of these packages, that are easy to make work again...
We could possibly regenerate the wrapper with Clang - but I'm not sure how worthwhile this is ;)

@ararslan
Copy link
Member

ararslan commented Nov 12, 2019

I think at one point @jrevels said he wanted to move the integrations for different codecs into separate packages or something like that, but I could be mistaken. That would make sense to me, then a package for FLAC integration could use the binaries directly or take a dependency on some revived version of FLAC.jl. Also that means that someone who needed FLAC integration (i.e. not us) could put the effort into making it happen 😛

@jrevels jrevels transferred this issue from another repository Dec 24, 2019
@jrevels jrevels changed the title using FLAC.jl port FLAC example to its own package Dec 24, 2019
@jrevels
Copy link
Member

jrevels commented Dec 26, 2019

A note for the future: it would also be nice for the FLAC example to demonstrate support for the relevant deserialize_lpcm(..., sample_offset, sample_count) method, since FLAC itself has built-in seek support.

@ericphanson
Copy link
Member

ericphanson commented Sep 1, 2021

looks like this was done in #89

edit: no, I misunderstood the scope of the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants