Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad DTO #200

Open
blokhin opened this issue Jul 25, 2024 · 1 comment
Open

Bad DTO #200

blokhin opened this issue Jul 25, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right

Comments

@blokhin
Copy link
Member

blokhin commented Jul 25, 2024

metis-gui/src/types/dto.d.ts

Line 31 in 378bfde

progress: number;

the progress field should be on the calculations, not on the datasources
@blokhin blokhin added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right labels Jul 25, 2024
@blokhin
Copy link
Member Author

blokhin commented Jul 26, 2024

Also, engine name and id are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blokhin