Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaking architecture: calling webhooks from GUI, mixing the logics of pagination vs. scheduler updates 😢 #133

Open
blokhin opened this issue Mar 24, 2023 · 1 comment
Open

Leaking architecture: calling webhooks from GUI, mixing the logics of pagination vs. scheduler updates 😢 #133

blokhin opened this issue Mar 24, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@blokhin
Copy link
Member

blokhin commented Mar 24, 2023

These are very bad things:

metis-gui/src/services/api.ts

Line 67 in 78a797d

postJSON(`/webhooks/calc_update${query}`, {})

https://github.com/basf/metis-bff/blob/6b86943a8d2c7310b82fcd9a332d44da503556ab/routes/%5Bversion%5D/webhooks/calc_update.js#L21

we have to refactor this at our earliest convenience...

FYI @pyoner @knopki
@blokhin blokhin added the enhancement New feature or request label Mar 24, 2023
@blokhin
Copy link
Member Author

blokhin commented Mar 24, 2023

cf. basf/metis-bff#74

@blokhin blokhin mentioned this issue Mar 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blokhin