Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New forum post notifications should happen on publish, not creation #104

Open
ghost opened this issue Dec 4, 2019 · 2 comments
Open

New forum post notifications should happen on publish, not creation #104

ghost opened this issue Dec 4, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 4, 2019

When a new forum post is created, a notification is sent to Gitter. That's all well and good, but if Akismet thinks the post might be spam, it un-publishes it. Then Gitter users get an 'access denied' message when clicking the link.

Can we change it so that notifications in Gitter only happen when a post is actually published?

@stpaultim
Copy link
Contributor

I agree that this would be good, but hopefully we can solve this #88 first.

@ghost
Copy link
Author

ghost commented Jan 5, 2021

Here's a PR: #116 but I'm not sure if it works properly or not since I can't actually test Akismet (i.e. submit spam and know that Akismet is going to unpublish it)... Any ideas @herbdool?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant