Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected method can not be overrided by Subclass in Kotlin. #37

Open
ShawnXiaFei opened this issue Jan 23, 2019 · 1 comment
Open

Protected method can not be overrided by Subclass in Kotlin. #37

ShawnXiaFei opened this issue Jan 23, 2019 · 1 comment

Comments

@ShawnXiaFei
Copy link

First, thanks for what you have done.
And then, there has a bug in CallRecordReceiver.kt. See the code below:

// Derived classes could override these to respond to specific events of interest
protected fun onRecordingStarted(context: Context, callRecord: CallRecord, audioFile: File?) {}

protected fun onRecordingFinished(context: Context, callRecord: CallRecord, audioFile: File?) {}

But, in Kotlin, they can not be overrided by subclass, you need to add open after protected.
I have forked you project and fix it, you can check it ShawnXiaFei/CallRecorder

Thanks again.

@aykuttasil
Copy link
Owner

Thank you. Actually, you can make PR for this subject?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants