Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock skew interceptor is only applied when constructing clients via fromEnvironment #1211

Closed
aajtodd opened this issue Feb 12, 2024 · 2 comments · Fixed by #1284
Closed
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue

Comments

@aajtodd
Copy link
Collaborator

aajtodd commented Feb 12, 2024

Describe the bug

The ClockSkewInterceptor is only applied via finalizeConfig which is only invoked when constructing clients via fromEnvironment

Expected behavior

ClockSkew should always be applied when constructing a client.

Current behavior

Clock skew may or may not be applied

Steps to Reproduce

N/A

Possible Solution

No response

Context

No response

AWS Kotlin SDK version used

1.0.51

Platform (JVM/JS/Native)

N/A

Operating System and version

N/A

@ianbotsf
Copy link
Contributor

ianbotsf commented Jun 6, 2024

This was fixed by smithy-lang/smithy-kotlin#1067 and #1284 back on 4/16.

@ianbotsf ianbotsf closed this as completed Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 This is a standard priority issue
Projects
None yet
2 participants