Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for shading #166

Open
adamthom-amzn opened this issue Mar 13, 2020 · 1 comment
Open

Add support for shading #166

adamthom-amzn opened this issue Mar 13, 2020 · 1 comment
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue

Comments

@adamthom-amzn
Copy link

It's currently not possible to shade aws-crt-java (rename its class files and native libraries and embed them into my own artifact). Renaming the class files itself works, but an UnsatisfiedLinkError is raised in software.amazon.awssdk.crt.CRT#awsCrtInit.

An ideal shading solution would allow for us to rename both the native libraries and the Java classes. As an example, Netty allows consumers to shade their classes and native libraries. They support a system property to allow customers to specify the prefix given to the libraries, though they later added support for automatically detecting the prefix. They also had to take special care to make sure multiple shaded versions of their library could coexist peacefully.

@bretambrose bretambrose added the feature-request A feature should be added or improved. label Sep 18, 2020
@yasminetalby yasminetalby added the p3 This is a minor priority issue label Jun 26, 2023
@yasminetalby yasminetalby added the needs-review This issue or pull request needs review from a core team member. label Oct 4, 2023
@yuzhu
Copy link

yuzhu commented Dec 6, 2024

+1, or appreciate any pointers to get around this issue. For now, the issue seems to be a temp lib copy is created to load and the CRT_LIB_NAME is a constant that can not be changed. Would changing CRT_LIB_NAME to a configurable value fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

4 participants