Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Pydantic 2.* as possible dependency #3644

Closed
EugeneLagonski opened this issue Aug 28, 2024 · 2 comments
Closed

Set Pydantic 2.* as possible dependency #3644

EugeneLagonski opened this issue Aug 28, 2024 · 2 comments
Labels
stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.

Comments

@EugeneLagonski
Copy link

EugeneLagonski commented Aug 28, 2024

Description
Pydantic was updated to the 2nd version but the library pins it to the 1st version. I checked the latest pydantic version (2.8.2) and all tests passed. (also successfully tested the Pydantic 2.0.0)

It's needed to minimize version conflicts in environments.

Related issue: #3617

Steps to reproduce

$git clone https://github.com/aws/serverless-application-model.git
$ cd serverless-application-model
$ python3 -m venv _e
$ . _e/bin/activate
(_e) $ pip install "-e .[dev]"
(_e) $ pip install pydantic==2.8.2
(_e) $ make test

Observed result

(_e) $ pip install pydantic==2.8.2
(_e) $ make test
Required test coverage of 95% reached. Total coverage: 95.85%

================================================================= 3988 passed in 72.79s (0:01:12) =================================================================

Additional environment details
OS: MacOS Sonoma 14.6.1 aarch64
If using the SAM CLI, sam --version: N/A
AWS region: N/A

@EugeneLagonski EugeneLagonski added the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label Aug 28, 2024
@EugeneLagonski EugeneLagonski closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
Copy link
Contributor

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.

@EugeneLagonski
Copy link
Author

EugeneLagonski commented Aug 29, 2024

Closing had an outdated version in the env where it was an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

No branches or pull requests

1 participant