You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the feature you'd like
The Sagemaker training toolkit and Python SDK use string literals for attribute values in many places. For instance, SMDDP is supported on P3, P3dn and P4D instances at the moment, and these are used as strings in tests and validation.
Code references:
If we want to deprecate support for an instance type, or add new instances for some features, we need to manually update all references here and in the SDK, potentially introducing bugs.
One solution is to maintain a central config or constants file with name mappings like SM_INSTANCE_NAME_P4D ='ml.p4d.24xlarge'; and then another central mapping for SUPPORTED_INSTANCE_TYPES_SMDDP, SUPPORTED_INSTANCE_TYPES_EFA, etc.
The text was updated successfully, but these errors were encountered:
Describe the feature you'd like
The Sagemaker training toolkit and Python SDK use string literals for attribute values in many places. For instance, SMDDP is supported on P3, P3dn and P4D instances at the moment, and these are used as strings in tests and validation.
Code references:
If we want to deprecate support for an instance type, or add new instances for some features, we need to manually update all references here and in the SDK, potentially introducing bugs.
One solution is to maintain a central config or constants file with name mappings like SM_INSTANCE_NAME_P4D ='ml.p4d.24xlarge'; and then another central mapping for
SUPPORTED_INSTANCE_TYPES_SMDDP
,SUPPORTED_INSTANCE_TYPES_EFA
, etc.The text was updated successfully, but these errors were encountered: