Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empy function args should specify a void #4952

Open
toidiu opened this issue Dec 4, 2024 · 0 comments
Open

Empy function args should specify a void #4952

toidiu opened this issue Dec 4, 2024 · 0 comments

Comments

@toidiu
Copy link
Contributor

toidiu commented Dec 4, 2024

Problem:

Old C compilers require specifying empty functions with a void arg. Some older functions are missing the void arg and should be updated: https://github.com/aws/s2n-tls/blob/main/crypto/s2n_openssl.h#L60-L62

bool s2n_libcrypto_is_awslc();

should be

bool s2n_libcrypto_is_awslc(void);

I havn't audited all functions so others might also exist.

Requirement

Wonder if there is a lint we can add to catch and prevent these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants