cargo features should be additive

[toidiu]

Problem:

As described here, cargo features should be additive and safe to compose because a package is built with the combination of features its dependencies enable.

This is not true for the no-network-tests feature. The consequence of this is that it is possible to accidentally disable network tests if the testing becomes more complicated.

It is important to call out that the risk is low because the integration crate is only used in internal testing so theoretically shouldn't be enabling the flag.

Solution:

Instead of gating the network tests behind a feature flag, does it make sense to make a separate binary that runs the network tests?

[lrstewart]

We also need to figure out how to handle the fips flag

[jmayclin]

Perhaps there is a solution here using a "named" group of features?

[features]
bmp = []
png = []
ico = ["bmp", "png"]
webp = []

https://doc.rust-lang.org/cargo/reference/features.html