You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is misleading because customer might see that the pq feature is off by default and conclude that PQ isn't supported by default.
However, PQ functionality/cryptography are available by default from aws-lc.
Solution:
I think the PQ feature should be removed from s2n-tls-sys and s2n-tls.
There is currently no meaningful functionality to be gated behind the PQ feature. In the future it might be useful to gate certain tests, but I think this could be more simply handled with a runtime feature probe or a env variable.
The text was updated successfully, but these errors were encountered:
Problem:
The
pq
feature is misleading for thes2n-tls
ands2n-tls-sys
crates.The only functionality gated behind this feature is the definition of a few
pq
policies.s2n-tls/bindings/rust/s2n-tls/src/security.rs
Lines 108 to 112 in 8dd4815
This is misleading because customer might see that the
pq
feature is off by default and conclude that PQ isn't supported by default.However, PQ functionality/cryptography are available by default from
aws-lc
.Solution:
I think the PQ feature should be removed from s2n-tls-sys and s2n-tls.
There is currently no meaningful functionality to be gated behind the PQ feature. In the future it might be useful to gate certain tests, but I think this could be more simply handled with a runtime feature probe or a env variable.
The text was updated successfully, but these errors were encountered: