Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASAN leak detection is disabled #2413

Open
boquan-fang opened this issue Dec 11, 2024 · 1 comment
Open

ASAN leak detection is disabled #2413

boquan-fang opened this issue Dec 11, 2024 · 1 comment

Comments

@boquan-fang
Copy link
Contributor

Problem:

We have enabled ASAN check for the CI in PR# #2410. However, seems like there are some global variables that aren't cleaned up which causes some indirect leak: test summary. Hence, for now, we have disabled the leak detection functionality of ASAN:

# We got a few globals that aren't cleaned up. Need to
# determine if we should reenable this in the future.
ASAN_OPTIONS: detect_leaks=false

Solution:

Audit those indirect leak message and fix those leaks.

Requirements / Acceptance Criteria:

R1: ASAN should pass, even when the detect leak option is set to true.

@camshaft
Copy link
Contributor

One thing to note is we do run a lot of our tests under MIRI, which does provide leak detection. ASAN checks would provide additional checks, especially where MIRI is too slow to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants