Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default TLS server builder has no with_cert_resolver #2178

Open
XeCycle opened this issue Apr 8, 2024 · 4 comments
Open

Default TLS server builder has no with_cert_resolver #2178

XeCycle opened this issue Apr 8, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation priority/medium Rank 3 size/small

Comments

@XeCycle
Copy link

XeCycle commented Apr 8, 2024

Problem:

s2n_quic::provider::tls::default::server::Builder does not have an equivalent of .with_cert_resolver on the rustls counterpart.

In #2173 (comment):

the best way to have a stable interface to integrate with is to use the TLS provider builders (client and server) that wrap the rustls implementation, rather than the re-exported rustls. If there are configuration options you need that are not provided in these builders, please open an issue and we will be happy to consider adding the functionality.

Solution:

IDK...

Requirements / Acceptance Criteria:

I used the rustls builder to support dynamically updating a rotated certificate, and to choose different certificates based on SNI server name in client hello messages. The current with_cert_resolver is a callback-style API; I'm okay with keeping this style, or we can also introduce a "certificate store" that can be updated and able to contain multiple certificates associated to different domain names. My use case currently does not involve wildcard certificates so a hashmap is enough, but maybe others would need more complex logic.

@toidiu
Copy link
Contributor

toidiu commented Apr 8, 2024

@XeCycle We are currently discussing how best we can provide rustls support going forward. Thanks you for your patience and sorry for the inconvenience.

@jkalez
Copy link

jkalez commented Apr 23, 2024

Similarly, it would be nice to have access to dangerous style things like Rustls exposes, namely custom certificate verifiers. We would like this to support behavior similar to curl -k.

@WesleyRosenblum
Copy link
Contributor

We'll add some documentation on how to work with Rustls in s2n-quic

@WesleyRosenblum WesleyRosenblum added documentation Improvements or additions to documentation priority/medium Rank 3 size/small labels May 16, 2024
@taikulawo
Copy link

Same like client_hello to lazy select ServerConfig
quinn-rs/quinn#2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority/medium Rank 3 size/small
Projects
None yet
Development

No branches or pull requests

5 participants