-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag templating #7506
Comments
Can you template this at the level above the NodeClass? I'm curious if rather than us supporting templating directly in our spec, if you can use something like Helm/Kustomize with GitOps to auto-template this out for you so the resultant manifests just have hard data. In general, I think it's pretty abnormal to see templated values in K8s resources that are directly applied to the cluster. |
I do use flux and kustomize to template things but in this case I don't think it would work as what I would really do is to use the NodePool name, e.g.: # Optional, propagates tags to underlying EC2 resources
tags:
Name: eks.amazonaws.com/{{ .ClusterName }}/{{ .NodePoolName }} |
When the Kubernetes project does templating, it's usually CEL. But: I agree, doing this at a level above NodePool / node class is the right approach. |
Description
What problem are you trying to solve?
I would like to be able to use go templates to generate dynamic AWS tags for the EC2 instances generated by karpenter, e.g:
How important is this feature to you?
Nice to have.
The text was updated successfully, but these errors were encountered: